Skip to content

Conversation

@DechengMa
Copy link
Contributor

@DechengMa DechengMa commented May 25, 2020

Implement sync beta tester feature when run sync beta group command.

Please merge #147 first.

📝 Summary of Changes

Changes proposed in this pull request:

  • Add Sync Beta Testers to Push beta group command, and some logic changes.
  • add readGroupAndTesters to BetaGroupProcessor
  • BetaTesterProcessor change producing file path logic, now using relative path to ./config/betagroup
  • BetaTester + Hashable, CodingKeys, SyncResourceProcessable
  • Tweak CSV reader, URL(string:) -> URL(fileURLWithPath:)

⚠️ Items of Note

TODO

🧐🗒 Reviewer Notes

💁 Example

Usage

asc testflight betagroup sync push [--input-path <input-path>] [--dry-run]

🔨 How To Test

swift run asc testflight betagroup sync push --dry-run
swift run asc testflight betagroup sync push

How To

Notes: Please run asc testflight betagroup sync pull first

Add a new tester to group

  1. find group linked tester csv file.(in group file, testers field)
    Add new invitee information, example:
Email,First Name,Last Name,Invite Type
// some existing testers...
foo@gmail.com,foo,bar,EMAIL // No Space between commas 
  1. Run command asc testflight betagroup sync push

Remove tester from group

  1. find group linked tester csv file
  2. Remove testers you want to delete in csv file. then save.
  3. Run command asc testflight betagroup sync push

Create group and testers together.

  1. create a csv file under ./config/betagroup folder (or input folder), input tester details like this,
Email,First Name,Last Name,Invite Type // MUST HAVE this header
foo@gmail.com,foo,bar,EMAIL
  1. Create a file, name whatever you like. under ./config/betagroup folder (or input folder)
app:
  bundleId: com.example.foo
groupName: a new group
testers: relative csv file path create in step 1. eg(`./config/betagroups/newgrouptesters.csv`)
  1. Run command asc testflight betagroup sync push

Update tester

Not supported by API

@DechengMa DechengMa added the enhancement New feature or request label May 25, 2020
@DechengMa DechengMa self-assigned this May 25, 2020
@DechengMa DechengMa force-pushed the testflight/sync-beta-testers branch from a68757a to b8b8574 Compare June 15, 2020 00:51
@DechengMa DechengMa force-pushed the testflight/sync-beta-testers branch from b8b8574 to 86c9459 Compare June 15, 2020 05:40
@DechengMa DechengMa changed the title Implement sync testers Implement sync testers in sync beta group command Jun 16, 2020
@DechengMa DechengMa marked this pull request as ready for review June 16, 2020 02:23
@DechengMa DechengMa marked this pull request as draft July 2, 2020 04:06
@DechengMa
Copy link
Contributor Author

File structure was redesigned so this is no longer needed

@DechengMa DechengMa closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants