fixed pflags binding bug #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jaekwon wants to merge 1 commit into jacobstr:master from tendermint:pflags_binding_fix

jaekwon commented Jan 9, 2015

Set() and Get() weren't compatible. Removed spurious(?) strings.ToLower(key).

Doesn't seem like it would break any existing behavior.


          fixed pflags binding bug

f82c8a0

Owner

jacobstr commented Jan 15, 2015

It looks like it's failing a test. The strings.ToLower isn't spurious - it's there for case-insensitive lookups.

I think what might be missing is a strings.ToLower in the Set method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet