Skip to content

IE Fix #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ethanspitz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

IE Fix #7

ethanspitz wants to merge 2 commits into from

Conversation

@ethanspitz
Copy link

@ethanspitz ethanspitz commented Mar 12, 2013

Adds script from https://code.google.com/p/stringencoders/source/browse/trunk/javascript/base64.js?r=230 and replaced atob with base64.decode. Now loads in IE.

@jamesward
Copy link
Owner

jamesward commented Mar 12, 2013

Can we shim the atob API on IE instead of changing the method call? Then people can optionally load base64.js if they want IE support.

Added conditional so base64.js file not required
08d9179 
File is only required for IE support
@ethanspitz
Copy link
Author

ethanspitz commented Mar 13, 2013

I wasn't 100% sure what you meant, because I have minimal experience in javascript, but I believe I did what you meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanspitz @jamesward