Fix failing checks #441
Open
Fix failing checks #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
did you get thorsten to sign off on this? shall we add him to the authors? |
Member
Author
|
@jonathon-love: I will wrote an e-mail to Thorsten Pohlert (author of PMCMR) with you in CC. Let's wait what he says and then take this further. However, @raviselker can already start to review the first commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should take care of the failing checks on GitHub (oldrel and devel). In addition, some lines of code are copied from PMCMR::posthoc.durbin.test in order to remove the dependency on that package which is deprecated (and will be removed with the next version of R).
The GitHub action for oldrel still fails (with some install.packages issue), however, when trying the code out in a docker / rocker container with R 4.4 (=oldrel) it works without problems.