Migrate build system to convention over configuration #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ArgListener listens for arguments passed to the CLI utilities by make. The arguments are transmitted via RPC. - MakeExecution runs Make, pointing to the Maker makefile while also mocking out the CLI utilities Make will be calling.
Using the Files type, it's very easy to quick build the directory structure you need to simulate a C++ build.
RunRules no longer support abritrary dependencies. They now only depend on the executable they run.
The `exec` and `slib` functions are no longer needed because user-defined config doesn't call them anymore.
- Removed error checking because it hasn't been tested and adds complexity for little in retun. - Removed config file definition as they aren't used.
This isn't required since we got the path by using find a moment earlier.
Moved testing code into regular executable instead of using the Golang testing framework.
Logging now is transmitted from readers to logger via a single channel instead of via multiple channels. This seems to improve output ordering and prevents the need for nilling channels.
- Added func for creating module makefile. - Cleaned up code. - Added breaking change to test. Need to update test data.
- Added jsock repository as git submodule in test-projects/ - Created GitHub Actions workflow to test Maker with jsock - Fixed 'file' function name conflict with GNU Make builtin (renamed to 'outputFile') - Fixed link flag ordering bug: libraries must come after object files in link command - Workflow builds jsock library and chat client as integration test These changes ensure Maker works correctly with real-world projects.
janderland
commented
Jan 7, 2026
janderland
commented
Jan 7, 2026
This merge brings in the convention-over-configuration approach: - Removed central config.mkr requirement - Auto-discovers modules by finding makefile in subdirectories - Per-module makefiles with simple variable declarations - Made all global config variables optional (using ?=) - Removed config parsing (no longer needs parser.pl for operation) - Added test framework for validation Conflicts resolved: - Updated rulesTempl to use 'ofile' (renamed from 'file' to avoid GNU Make builtin conflict) - Removed runDeps parameter (not used in implicit_configuration)
…ilds Bug fixes: - Fixed mindepth from 1 to 2 to prevent recursive makefile inclusion (mindepth 1 includes files in current directory, causing infinite loop) Workflow updates: - Updated GitHub Actions workflow to use convention-based approach - Workflow now creates per-module makefiles instead of using config.mkr - Each module directory gets a simple makefile with 4 variables: moduleType, moduleDeps, moduleCompFlags, moduleLinkFlags This completes the migration to convention over configuration!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensure Maker works correctly with real-world projects.