Support for releases without the stable_id tables #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of the set_table_name and set_primary_key)
…to rounr the frequency to two decimals.
…65 and after) Issue #20
…65 and after) Issue #20
Author
|
Ah, and I forgot to mention. I updated the code to stop using set_primary_key to self.primary_key to use the latest conventions on active record. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jan,
I just added code to fix the find_by_stable_id functions and stable_id properties in exon, gene, transcript and translation, to support the changes introduced in schema 65. I ran the test for version 60 to see if I didnt brake anything, and seems ok. I also added tests for the functions I changed calling the ensemble genes version 70. Originally, I intended to use the release from the get_info method, but I found it would complicate the version on ensemble genomes, as the release are not the same as the API version there. So I coded a function that detects if the stable_id tables are present or not, and store that as a class variable in the Base. That is reset each time a new connection is done. So, the overhead of detecting which version of the code shouldn't be noticeable.
Fixes: #11
Cheers
Ricardo.