Enable bypassing Azure Key Vault #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason permissions to Azure Key Vault aren't working for me so I plumbed through an alternative to do local development on runfo. See Documentation/DevWithoutKeyVault for details on the workflow. Code-wise the primary changes are checking the USE_KEYVAULT environment variable and some refactoring of the GitHubClientFactory to support using the logged in user's OAuth token rather than the Runfo GH app official identity. I also added the IConfiguration.GetNonNull() extension method and used it in various places to proactively generate errors when the environment has not provided configuration settings the app is relying on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason permissions to Azure Key Vault aren't working for me
so I plumbed through an alternative to do local development on runfo.
See Documentation/DevWithoutKeyVault for details on the workflow.
Code-wise the primary changes are checking the USE_KEYVAULT environment
variable and some refactoring of the GitHubClientFactory to support using
the logged in user's OAuth token rather than the Runfo GH app official
identity. I also added the IConfiguration.GetNonNull() extension method and
used it in various places to proactively generate errors when the environment
has not provided configuration settings the app is relying on.