Force UTF-8 encoding when reading HAR files #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would you consider making the HAR file encoding more explicit? http://www.softwareishard.com/blog/har-12-spec/ says that HAR archives must be in UTF-8 format. An approach like this proposed change could fix issues on operating systems in which the default file encoding is not UTF-8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you consider making the HAR file encoding more explicit here?
http://www.softwareishard.com/blog/har-12-spec/ says that HAR archives must be in UTF-8 format. An approach like this proposed change could fix issues on operating systems in which the default file encoding is not UTF-8. For example, the default encoding on official Ruby docker images is US-ASCII, which creates problems when reading some HARs.
This line has been unchanged for 6 years, so changing it now could cause backwards compatibility issues in the general case. I am able to work around this problem locally by monkey-patching this class.