Fix: Auto-trigger Build workflow for auto-created dependency PRs #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRs created by GitHub Actions using GITHUB_TOKEN don't trigger other workflows (GitHub security feature). This adds: 1. workflow_dispatch trigger to build.yml enabling manual/API triggers 2. Auto-trigger of Build workflow after dependency PR creation This ensures native dependency update PRs get CI coverage automatically.
jas88
force-pushed
the
fix/auto-trigger-build-for-dependency-prs
branch
from
c96eafd to
764cd6f
Compare
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 5d7cbd0..c96eafd
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (2)
• .github/workflows/build.yml
• scripts/check-native-updates.sh
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PRs created by GitHub Actions using
GITHUB_TOKENdon't trigger other workflows (GitHub security feature to prevent recursive loops). This was causing native dependency update PRs (like #192) to not get CI coverage.Changes
.github/workflows/build.yml: Addedworkflow_dispatchtrigger to enable manual/API triggeringscripts/check-native-updates.sh: Added auto-trigger of Build workflow after dependency PR creationTesting
After merging this PR:
gh workflow run build.yml --ref <branch>Related
This fix will enable CI on #192 once merged.
High-level PR Summary
This PR fixes a CI coverage gap by enabling the Build workflow to be triggered for dependency update PRs that are auto-created by GitHub Actions. Since GitHub prevents workflows triggered by
GITHUB_TOKENfrom recursively triggering other workflows, the solution addsworkflow_dispatchto the Build workflow configuration and updates the dependency update script to manually trigger the Build workflow after creating a PR.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
.github/workflows/build.ymlscripts/check-native-updates.shSummary by cubic
Ensure CI runs on dependency PRs created by our GitHub Action by auto-triggering the Build workflow and allowing manual/API runs. Unblocks CI for PRs like #192.
Written for commit 764cd6f. Summary will update on new commits.