-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: added MetadataJdkInstaller
#94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@maxandersen I created this Java Metadata based installer and it works perfectly. There's only one thing that we might want to consider: the metadata API separates the lists for GA and EA and for Temurin and AOJ. To be as similar as the Foojay installer it actually does 4 requests, to get GA and EA versions for Temurin and GA and EA versions for AOJ. We should think if we can make this more efficient. The first thing I just realize is that EA versions for AOJ doesn't make much sense, so that would at least reduce things to 3 requests. |
1c6ba2f to
c00907a
Compare
|
Is the intent this will be default or a fallback? How about the initial boothup? |
Don't know yet. In this PR I made it the default, but that's just the devkitman default which JBang overrides anyway, so the default isn't actually used there. Making it the default in JBang would mean a change in JBang. But I'm not sure. On the one hand we have a more reliable service with Metadata, but on the other hand we have a more extensive catalog with Foojay which includes EAs that are very useful.
Yes, I hadn't actually thought about that yet, but that's definitely something not handled by devkitman. That should be an issue in the JBang repo. But to at least answer the question here: yes that would be a problem because the Metadata API doesn't allow filtering, or getting only a single URL result. Opened an issue for that: jbangdev/jbang#2377 |
We now support specifying a cache directory for JDK installers.
c00907a to
f64be25
Compare
No description provided.