Added support for paused status in stages that are waiting for input #1068

rockleez · 2025-11-26T14:39:47Z

Added support for a paused stages

Displays the paused glyph (two bars) instead of the running spinner when a stage is waiting for input

Fixes #967

Testing done

Ran a test pipeline that included the input steps in a parallel and stage view.
Validated that the timer and pipeline status continued counting up
Validated that the Pipeline Overview, Console view, Stages view reflected the paused status icon
Validated that the pipeline remained in the In Progress state
Added a unit test

Before:
Stage appears as running even though its waiting for input

After:
Stage appears as paused on Pipeline Overview and Console view

Stage appears as paused on Stages view

Including parallel branches

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests that demonstrate the feature works or the issue is fixed

…nput

src/main/frontend/setupTests.ts

src/main/frontend/pipeline-graph-view/pipeline-graph/main/PipelineGraphModel.tsx

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineStage.java

… not used

…peline-graph-view-plugin into paused_stage_updates

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineStage.java

src/main/frontend/common/components/status-icon.spec.tsx

janfaracik · 2025-12-08T08:15:39Z

Looks fine to me on a frontend POV now - any thoughts on Java @timja @lewisbirks

timja

Hey looks good couple of minor things, but close.

timja · 2025-12-08T09:03:52Z

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineGraphApi.java

        List<PipelineStageInternal> stages = getPipelineNodes(builder);

+        // Set the builder on each stage so they can check for paused steps
+        if (builder instanceof PipelineStepBuilderApi stepBuilder) {


A separate PR could refactor the need for this instanceof check pretty easily, there's only one implementation and the indirection is no longer needed

timja · 2025-12-08T09:04:51Z

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineStageInternal.java

+        if (children != null && !children.isEmpty()) {
+            for (PipelineStage child : children) {
+                if (child.state == PipelineState.PAUSED) {
+                    return true;


Could we get some test coverage for this please?

A pipeline that sets an input step on it and validates the stage is now paused.

timja · 2025-12-08T09:06:16Z

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineStageInternal.java

        this.agent = aAgent;
    }

+    public void setBuilder(PipelineStepBuilderApi builder) {


this could be avoided by doing the refactoring mentioned in PipelineGraphApi comment and then you could just pass the builder in the constructor (or another constructor) as I'd prefer not to be mutating state

timja · 2025-12-08T10:07:06Z

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineStageInternal.java

+    }
+
    public PipelineStage toPipelineStage(List<PipelineStage> children, String runUrl) {
+        boolean waitingForInput = isWaitingForInput(children);


can we only do this check if there is an InputAction attached to the WorkflowRun?

I think that should be optimisable so this check is only run over stages that could be waiting for input?

…peline-graph-view-plugin into paused_stage_updates

samrocketman · 2025-12-11T00:37:01Z

I didn't realize this PR was open when I created the following issues.

samrocketman · 2025-12-11T00:38:26Z

It's a bit challenging to relay how good this would be.

An example: you have a pipeline with 30 stages stacked in parallel. If only one stage is paused for input, then you must either wait for most of the stages to finish before you can answer (the "last" one running is input) or you need to manually open each of the 30 stages. The last one is a bit tedious to identify in the log steps there's a pause indicating input is required.

timja · 2025-12-11T09:11:37Z

It's a bit challenging to relay how good this would be.

An example: you have a pipeline with 30 stages stacked in parallel. If only one stage is paused for input, then you must either wait for most of the stages to finish before you can answer (the "last" one running is input) or you need to manually open each of the 30 stages. The last one is a bit tedious to identify in the log steps there's a pause indicating input is required.

😄, it should be in soon, only a bit of polish needed.

timja · 2025-12-11T09:14:07Z

Note: need to confirm if this fixes #348

sgleske-ias · 2025-12-11T17:25:21Z

I was going to test this with incrementals but incrementals apparently only supports Jenkins weekly releases. I get this error on LTS Jenkins Version 2.528.3

Failed to load: Pipeline Graph View Plugin (pipeline-graph-view 745.v25917da_3f244)
 - Jenkins (2.534) or higher required

(note: I am samrocketman; this is my proprietary GitHub profile)

timja · 2025-12-11T17:36:07Z

It’s not that incrementals supports weekly’s it’s that there’s a wider design rework going on which this plugin is integrating with so has needed to depend on a more recent release in its latest versions.

sgleske-ias · 2025-12-11T18:54:35Z

Sounds good I will test in the next LTS update if this PR is not merged by that time. I have a several non-prod test environments but at the moment we generally ship LTS (I could consider making updates to support weekly at some point but for now it's all revolving around LTS).

…ence

rockleez · 2025-12-12T11:14:57Z

I've made the requested changes, and manually validated via a test pipeline that functionality is still the same.

Leemalin Moodley added 6 commits November 26, 2025 16:37

fix: added support for paused status in stages that are waiting for i…

fdea504

…nput

fix: updated result color for paused icon

bb3e1eb

fix: added a test and fixed bad test setup

82b0bb6

chore: updated pipeline model

8894ffa

fix: fixed code style issues

a8c3093

fix: more formatting fixes

c063d88

rockleez marked this pull request as ready for review November 27, 2025 12:53

rockleez requested a review from a team as a code owner November 27, 2025 12:53

janfaracik reviewed Nov 27, 2025

View reviewed changes

src/main/frontend/setupTests.ts Outdated Show resolved Hide resolved

fix: removed storage implementation for tests

ea480b6

janfaracik reviewed Dec 1, 2025

View reviewed changes

src/main/frontend/pipeline-graph-view/pipeline-graph/main/PipelineGraphModel.tsx Outdated Show resolved Hide resolved

Leemalin Moodley and others added 2 commits December 2, 2025 08:55

fix: removed waitingForInput from PipelineGraphModel

0f36e99

Merge branch 'main' into paused_stage_updates

ec00207

timja added the enhancement New feature or request label Dec 2, 2025

timja changed the title ~~fix: added support for paused status in stages that are waiting for i…~~ Added support for paused status in stages that are waiting for input Dec 2, 2025

janfaracik reviewed Dec 2, 2025

View reviewed changes

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineStage.java Outdated Show resolved Hide resolved

Leemalin Moodley added 2 commits December 2, 2025 13:34

fix: removed additional references to waiting for input that were are…

9744231

… not used

Merge branch 'paused_stage_updates' of https://github.com/rockleez/pi…

7eadf51

…peline-graph-view-plugin into paused_stage_updates

janfaracik reviewed Dec 3, 2025

View reviewed changes

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineStage.java Outdated Show resolved Hide resolved

janfaracik reviewed Dec 3, 2025

View reviewed changes

src/main/frontend/common/components/status-icon.spec.tsx Outdated Show resolved Hide resolved

Leemalin Moodley and others added 4 commits December 8, 2025 09:09

refactor: moved logic for paused stages into PipelineStageInternal

0d4b320

refactor: removed unnecessary test step

22ed4cc

Fix lint

cc945d7

chore: codestyle fixes

a2c9140

janfaracik approved these changes Dec 8, 2025

View reviewed changes

rockleez and others added 2 commits December 8, 2025 10:15

Merge branch 'main' into paused_stage_updates

e08ddb0

Use pattern variable

25917da

timja reviewed Dec 8, 2025

View reviewed changes

Leemalin Moodley added 2 commits December 9, 2025 08:25

Merge branch 'paused_stage_updates' of https://github.com/rockleez/pi…

ec60184

…peline-graph-view-plugin into paused_stage_updates

fix: added test for input pause

b9b21c4

samrocketman mentioned this pull request Dec 11, 2025

UI does not clearly indicate user input is required #1085

Closed

refactor: optimize input step detection by checking InputAction exist…

337faa3

…ence

Added support for paused status in stages that are waiting for input #1068

Are you sure you want to change the base?

Added support for paused status in stages that are waiting for input #1068

Conversation

rockleez commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Submitter checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janfaracik commented Dec 8, 2025

Uh oh!

timja left a comment

Choose a reason for hiding this comment

Uh oh!

timja Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

timja Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

timja Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

timja Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

samrocketman commented Dec 11, 2025

Uh oh!

samrocketman commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timja commented Dec 11, 2025

Uh oh!

timja commented Dec 11, 2025

Uh oh!

sgleske-ias commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timja commented Dec 11, 2025

Uh oh!

sgleske-ias commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rockleez commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rockleez commented Nov 26, 2025 •

edited

Loading

samrocketman commented Dec 11, 2025 •

edited

Loading

sgleske-ias commented Dec 11, 2025 •

edited

Loading

sgleske-ias commented Dec 11, 2025 •

edited

Loading