Feature/task 7 formik #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vladyslav-Velytskyi
left a comment
Vladyslav-Velytskyi
left a comment
There was a problem hiding this comment.
Probably validation message has it's own style
but you have an another, please, fix it
|
|
||
| const MovieSchema = Yup.object().shape({ | ||
| title: Yup.string().required(), | ||
| url: Yup.string().required(), |
Collaborator
There was a problem hiding this comment.
It will be logically if it has url validation, because random string couldn't be a url. Yup has api for it
Suggested change
| url: Yup.string().required(), | |
| url: Yup.string().url().required(), |
| title: Yup.string().required(), | ||
| url: Yup.string().required(), | ||
| releaseDate: Yup.string().required(), | ||
| rating: Yup.number() |
Collaborator
There was a problem hiding this comment.
For number you can use min() and max()
Suggested change
| rating: Yup.number() | |
| rating: Yup.number(),min(0).max(10) |
| return val >= 0 | ||
| }), | ||
| overview: Yup.string().required() | ||
| }) |
Collaborator
There was a problem hiding this comment.
Also you can check data types in the backend side, they use Joi library, it's almost the same to Yup
| value={formik.values.title} | ||
| onBlur={formik.handleBlur('title')} | ||
| /> | ||
| {formik.touched.title && formik.errors.title} |
Collaborator
There was a problem hiding this comment.
Create a simple component which will render error according to mockup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.