Support for ElementCollection and transient collections #4930
+4,837
−3,247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knstvk
commented
Dec 23, 2025
| return CollectionUtils.isEqualCollection(newValue, oldValue); | ||
| } | ||
|
|
||
| protected void setCollectionValue(E item, @Nullable V value) { |
Contributor
Author
There was a problem hiding this comment.
Before this change, MultiValuePicker and similar components could not be bound to a Set attribute.
knstvk
commented
Dec 23, 2025
| } | ||
| throw new RuntimeException("Unsupported by lazy loading"); | ||
| // Called e.g. by not-instantiated IndirectList.add() | ||
| return originalValueHolder.getMapping(); |
Contributor
Author
There was a problem hiding this comment.
Before this change, calling add() on a lazily loaded collection thrown an exception.
glebfox
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.