Pinyin fixes #2
Open
Pinyin fixes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnheroy
reviewed
Mar 6, 2017
|
|
||
| _.each(words, function(word) { | ||
| var pronunciation = word.pronunciation; | ||
| var prettified = pinyin.prettify(pronunciation.slice(1, pronunciation.length - 1).replace(/u\:/g, "v")); |
johnheroy
reviewed
Mar 6, 2017
Owner
johnheroy
left a comment
johnheroy
left a comment
There was a problem hiding this comment.
Thanks for the PR! Sorry for getting back so late on this. Just a question about whitespace--also for Sequelize what does the "logging: false" option do?
Contributor
Author
|
No worries. The logging option disables the logging that Sequelize does during each query or it'll ends up polluting logs when using this as a library in another project when enabled. As for the whitespace I can't quite tell what the rule is or remember. Is it tabs or spaces? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with pinyin searching for example properly detecting dead tones, converting
ü & vcharacters tou:, and updated database to have all pinyin lower cased for proper detection of proper nouns.