Testing for direct send rpc api #809
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitx13
added
the
blocked
amitx13
added
the
rpc-api
Collaborator
|
First simple tests have been successful. Will let you know once I have made further progress. Looks promising 🚀 |
Collaborator
|
Hey @amitx13! Thanks for PR - it was quite nice testing the changes with the code you provided. |
Contributor
Author
|
Hey @theborakompanioni Thanks for testing and reviewing the PR. Appreciate the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to test the
Direct-Send RPC APIto ensure compatibility with recent changes. The key updates include modifications to theselected_utxosparameter.@theborakompanioni could you please test the changes and confirm that they do not introduce any issues with Jam? Your confirmation will allow us to proceed with JoinMarket-Org/joinmarket-clientserver#1721 PR.
Disclaimer
Please do not merge this PR. The purpose of this PR is solely to test the changes and ensure compatibility. It is not intended for merging into the main codebase.