Coreen Cooper #168
Open
Coreen Cooper #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4fc3ad1.
Contributor
Yep, it's because the main repo changed since the last time your forked or pulled. Probably won't happen too often but nothing to worry about. |
| // // circumference = 2PI * radius // note to self | ||
| // // console.log(Math.PI) //note to self | ||
| // // console.log((2 * Math.PI) * radius) // note to self | ||
| // let circumferenceResult = (Math.round(2 * 3.141592653589793) * radius) |
Contributor
There was a problem hiding this comment.
Nice using Math.PI, keep using it. Also about to do Math.pow(radius, 2)
|
|
||
| // Hint: | ||
| // Use the remainder % operator. | ||
| //console.log(123%5) |
Contributor
There was a problem hiding this comment.
Have spaces around operators for better readability.
problems/variables.js
Outdated
| // * Years that are divisible by 100 are not leap years if they are not also divisible by 400. | ||
| // * For example 1900 was not a leap year, but 2000 was. Print "Leap year!" or "Not a leap year!" depending on the year you are provided. | ||
|
|
||
| console.log("ran out of time to solve, but I will keep trying. Got stuck on the math.") |
Contributor
There was a problem hiding this comment.
No problem, was a bonus. Good effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Corey,
Is the warning: "X Can't automatically merge."normal? If not, do you have any idea what I did wrong?