Andres Ballares #176
Open
Andres Ballares #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problems/variables.js
Outdated
| // * For example, if you were born in 1988, then in 2026 you'll be either 37 or 38, depending on what month it is in 2026. | ||
| // * Log them to the screen like so: "I will be either `ageMin` or `ageMax` in `futureYear`", substituting the values. | ||
|
|
||
| let birthYear = '1977' |
Contributor
There was a problem hiding this comment.
birthYear should be const
problems/variables.js
Outdated
| // * Log them to the screen like so: "I will be either `ageMin` or `ageMax` in `futureYear`", substituting the values. | ||
|
|
||
| let birthYear = '1977' | ||
| let futureYear = '2021' |
Contributor
There was a problem hiding this comment.
Values should be numbers not strings
problems/variables.js
Outdated
|
|
||
| let birthYear = '1977' | ||
| let futureYear = '2021' | ||
| let minimumAge = '44' |
Contributor
There was a problem hiding this comment.
These should be derived from the previous variables.
problems/variables.js
Outdated
| // * Log the result to the screen like this: "You will need `snackNumber` to last you until the age of `maxAge`". | ||
|
|
||
| // ## Problem Three | ||
| let curAge = "30" |
Contributor
There was a problem hiding this comment.
numbers should be numbers not strings
problems/variables.js
Outdated
|
|
||
|
|
||
| let radius = "2" | ||
| let circumferenceOfCircle = Math.PI * radius |
Contributor
There was a problem hiding this comment.
Good use of my library
|
|
||
| let radius = "2" | ||
| let circumferenceOfCircle = Math.PI * radius | ||
| let areaOfCircle = Math.PI * (radius * 2) |
Contributor
There was a problem hiding this comment.
pi * r ^ 2. so radius**2
problems/variables.js
Outdated
| // * Now store a fahrenheit temperature into a variable. | ||
| // * Convert it to celsius and output "`tempInFahrenheit`°F is `tempInCelsius`°C." | ||
|
|
||
| let celsius = "23C°" |
Contributor
There was a problem hiding this comment.
these should be numbers representing degrees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.