Stack overflow error when opening large CSV files ("Maximum call stack size exceeded") #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening CSV files with many rows causes the extension to crash with
RangeError: Maximum call stack size exceeded.Stack trace:
Steps to reproduce
Root Cause
The extension uses
Math.max(...array)spread syntax in multiple locations to calculate the maximum column count.When the CSV has many rows, spreading the array into
Math.max()exceeds JavaScript's call stack limit (~65K arguments).Fix suggestion
Use a stack-safe approach through using
reduce()