#56 - DinersClub validation #59
Conversation
| assert(payform.validateCardNumber('4917300800000000'), 'visaelectron') | ||
|
|
||
| assert(payform.validateCardNumber('6759649826438453'), 'maestro') | ||
| assert(payform.validateCardNumber('639002000000000003'), 'maestro') |
There was a problem hiding this comment.
You can keep those 4 tests, they are from this commit: 5257fca
| { | ||
| type: 'maestro' | ||
| pattern: /^(5018|5020|5038|6304|6390[0-9]{2}|67[0-9]{4})/ | ||
| pattern: /^(5018|5020|5038|6304|6703|6708|6759|676[1-3])/ |
There was a problem hiding this comment.
You can revert back to this:
| pattern: /^(5018|5020|5038|6304|6703|6708|6759|676[1-3])/ | |
| pattern: /^(5018|5020|5038|6304|6390[0-9]{2}|67[0-9]{4})/ |
| ### Maestro <img src="https://user-images.githubusercontent.com/6437556/45498343-d17d2200-b747-11e8-8a17-7768071a0f2f.png" width="30" height="20"> | ||
|
|
||
| **IIN Pattern:** 5018, 5020, 5038, 6304, 639000 to 639099, 670000 to 679999 <sup>[12], [13]</sup> | ||
| **IIN Pattern:** 5018, 5020, 5038, 6304, 6703, 6708, 6759, 676[1-3] <sup>[12]</sup> |
There was a problem hiding this comment.
This can be reverted as well:
| **IIN Pattern:** 5018, 5020, 5038, 6304, 6703, 6708, 6759, 676[1-3] <sup>[12]</sup> | |
| **IIN Pattern:** 5018, 5020, 5038, 6304, 639000 to 639099, 670000 to 679999 <sup>[12], [13]</sup> |
| [12]: http://blog.unibulmerchantservices.com/12-signs-of-a-valid-mastercard-card/ | ||
| [13]: https://www.mastercard.us/content/dam/mccom/global/documents/mastercard-rules.pdf | ||
| [13]: https://en.wikipedia.org/wiki/Payment_card_number#Issuer_identification_number_(IIN) | ||
|
|
There was a problem hiding this comment.
Small fish — we can remove the empty new lines
|
Hi @ddayguerrero i rebased it from your repo :) |
|
Nice! Consider my latest comments please and we should be good! 😊 |
|
I've changed the regex for Dinersclub in order to include also the 39... cards as per Wikipedia rules |
|
Nice! We're only missing the changes mentioned in the comment then we're set! |
* Adds support for detaching events from input fields * Updates jQuery plugin API * Updates plugin documentation * Refactors methods to attach and detach events
|
Hi @ddayguerrero i've rebased from 1.4.0 release. |
3 participants
Hi @ddayguerrero,
i hope this is the right one :)
Thanks,
Francesco