Bugfix/63 caret moved to the end #64
Conversation
package.json
Outdated
| "devDependencies": { | ||
| "browserify": "^16.2.3", | ||
| "bundle-collapser": "~1.1.1", | ||
| "bundle-collapser": "^1.3.0", |
There was a problem hiding this comment.
Any specific reason why we're bumping the version for bundle-collapser?
There was a problem hiding this comment.
not really, it is automatically updated during the installation.
I have reverted it.
Could you help me to better understand what do you need, please? |
ddayguerrero
left a comment
ddayguerrero
left a comment
There was a problem hiding this comment.
Sorry if I was unclear, you do not need to include the /dist folder for this pull request. We'll compile and minify everything once the new update is ready for publication.
I tested out the changes with the LTR index page and everything works well. RTL still loses its position but that behaviour is still the same on master, so we can fix it separately.
|
@ddayguerrero , I see, no problem I have reverted the code into |
|
If you don't mind then that would be cool @andygi! |
@ddayguerrero Sure, I have done! |
|
Sorry, but we actually want to not ignore that directory, we need it for package managers (like bower) that require we commit the compiled files. https://github.com/jondavidjohn/payform/blob/master/bower.json#L3 |
|
Right, I completely missed that @jondavidjohn! Thanks for 👀, we can undo that change @andygi |
|
@ddayguerrero , no problem I have reverted the commit. |
3 participants
Bugfix of #63 (Caret moved to the end of input after change).
Fixed for LTR only and testable manually only, by index.html and jquery.html.
In the ticket there a clear description of how to reproduce the issue and, consequently how to test it.
I have created a jquery and javascript index RTL page in order to test RTL as well.