#160 check node version at startup per package.json / engines

.github/workflows/test.yml

@@ -17,6 +17,7 @@ jobs:
       uses: actions/setup-node@v4
       with:
         node-version: 18
+    - run: npm cache clean --force
     - run: npm ci
     - run: npm test
     # @todo #0:1h use --test-coverage-exclude to exclude tests from cov

lib/NodeVersion.js

@@ -0,0 +1,17 @@
+class NodeVersion {
+	constructor (engines, nodeVersion) {
+		this.minMajor = parseInt(engines.node.split('>=')[1])
+		this.major = parseInt(nodeVersion.split('.')[0])
+		this.version = nodeVersion
+	}
+
+	isValid () {
+		return this.major >= this.minMajor
+	}
+
+	toError () {
+		return `Node.js ${this.minMajor}+ required (current: v${this.version})`
+	}
+}
+
+module.exports = NodeVersion

mr.js

@@ -2,6 +2,8 @@
 const ParsedArgs = require('./lib/ParsedArgs')
 const MrCommand = require('./lib/MrCommand')
 const RunCommand = require('./lib/RunCommand')
+const NodeVersion = require('./lib/NodeVersion')
+const pkg = require('./package.json')
 
 const main = async (argv) => {
 	await new RunCommand (
@@ -17,6 +19,12 @@ module.exports = {
 	main
 }
 
+const nodeVersion = new NodeVersion(pkg.engines, process.versions.node)
+if (!nodeVersion.isValid()) {
+	console.error(nodeVersion.toError())
+	process.exit(1)
+}
+
 // eslint-disable-next-line no-floating-promise/no-floating-promise
 ; (async () => {
 
@@ -27,8 +35,6 @@ module.exports = {
 	try {
 		await main (process.argv.slice (2))
 	} catch (x) {
-		console.error(`Node.js version: ${process.version}`)
-		console.error(x.message.split('\n')[0])
 		process.exit(1)
 	}
 

package.json

@@ -3,6 +3,9 @@
   "version": "0.1.12",
   "description": "yet another git flow cli",
   "main": "mr.js",
+  "engines": {
+    "node": ">=18"
+  },
   "publishConfig": {
     "access": "public"
   },

tests/NodeVersion.js

@@ -0,0 +1,26 @@
+const {describe, it} = require('node:test')
+const assert = require('assert')
+const NodeVersion = require('../lib/NodeVersion')
+
+describe('NodeVersion', () => {
+
+	it('valid when major >= min', () => {
+		const v = new NodeVersion({node: '>=18'}, '20.10.0')
+		assert.ok(v.isValid())
+	})
+
+	it('valid when major == min', () => {
+		const v = new NodeVersion({node: '>=18'}, '18.0.0')
+		assert.ok(v.isValid())
+	})
+
+	it('invalid when major < min', () => {
+		const v = new NodeVersion({node: '>=18'}, '16.20.0')
+		assert.ok(!v.isValid())
+	})
+
+	it('toError returns message', () => {
+		const v = new NodeVersion({node: '>=18'}, '16.20.0')
+		assert.equal(v.toError(), 'Node.js 18+ required (current: v16.20.0)')
+	})
+})