Skip to content

Conversation

@szubersk
Copy link
Contributor

No description provided.

Signed-off-by: szubersk <szuberskidamian@gmail.com>
@jtesta
Copy link
Owner

jtesta commented Mar 27, 2025 via email

@jtesta
Copy link
Owner

jtesta commented Apr 18, 2025

After thinking about this more, I have the following question: why would a new lambda_handler() function entry point be necessary, instead of simply running ssh-audit using Python's subprocess module? The advantage to using subprocess is that the existing command-line interface is already well-tested and well-supported.

If this new function only makes things slightly easier for end users, then I'd say its not worth the long-term maintenance cost; it would instead need to make things significantly easier to justify the added cost of maintenance and testing.

@jtesta
Copy link
Owner

jtesta commented Aug 30, 2025

Since invoking the tool as a new process seems to be the best way to do this in AWS Lambda (both from a user's perspective, as well as from a code maintenance perspective), I suppose I'll close this PR.

@szubersk : if you can provide a scenario where it makes sense to use & maintain a wrapper, I'd be eager to hear it! Regardless, I appreciate the effort you've put in!

@jtesta jtesta closed this Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants