Local file link handling #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handles links to files both (pretty consistently) in the Vault and (at least when they are <2GiB) elsewhere on disk; Fixes juliang22#20 - Insert a button when the Open Local Video modal is used, which by the way I made a little less generic than in juliang22#13 - Ignore/Strip markdown wrapping when invoking the "Open Video player" action: this is helpful with vault-local files cause you can drag them from the side-bar or use autocomplete to get them referenced before turning into link
donaldguy
commented
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works, but buggy: Handle local file links
Handles links to files both (pretty consistently) in the Vault and (at
least when they are <2GiB) elsewhere on disk; Fixes Support local files with obsidian links or relativ path #20
Insert a button when the Open Local Video modal is used, which by the
way I made a little less generic (in terms of name in code and command palette) than in closes #4; add local video support #13
Ignore/Strip markdown wrapping when invoking the "Open Video player"
action: this is helpful with vault-local files cause you can drag them
from the side-bar or use autocomplete to get them referenced before
turning into link
also ran
npm audit fixIssues:
as noted, files referenced by absolute path will not load if bigger than 2 GiB, this is a limitation of node's
fsmodule - the workaround using streams is possible but not apparently accessible through the Obsidian APIsIn testing there were various times where (especially after clicking two links in quick succession) the video pane got wedged with the play/pause button flashing and no playback. I think this bug may pre-exist this work, but I am not sure
Anyway, idk if you want to take this, but I accidentally worked on it for the last several hours so might as well open the PR