Support Ruby 3 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yagi
added a commit
to y-yagi/retriable
that referenced
this pull request
Feb 25, 2025
It seems that `retriable_proxy` isn't being maintained. It doesn't work with Ruby 3.x. Ref: julik/retriable_proxy#2
kamui
pushed a commit
to kamui/retriable
that referenced
this pull request
Feb 26, 2025
It seems that `retriable_proxy` isn't being maintained. It doesn't work with Ruby 3.x. Ref: julik/retriable_proxy#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods with keywords argument no longer work with RetriableProxy in Ruby 3.0 due to this change: Separation of positional and keyword arguments in Ruby 3.0
This change supports makes keyword arguments supported for Ruby 2.7 and up. I could potentially add support for Ruby 2.6, but it's going to be EOL soon.
Didn't run tests or add tests but figured I'd open this as a start.