Feat / WCAG validation per page using axe-playwright
#693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: movie screen composition * chore: use background image for movie screens * chore: allow one child in media hero buttons * chore: correct button styling for trailer button inlinelayout * chore: improve typing for children prop
* fix(i18n): update i18n keys * chore(tests): update snapshot * fix(i18n): improve period translation key
#682) * feat: add reference demo implementation for landing page labels filtering * feat: add simple check for mobile view * feat: use breakpoint check from hooks * feat: use filtering hook * feat: add filter code, filter logic to be implemented * feat: remove unworking logic, leave first example filtering * feat: code cleanup to only include device filtering * feat: update labels * feat: add filtering based on day of week * feat: filter content based on country - a few examples added * feat: simplify filtering, fix logic to check multiple labels * feat: separate filter into functions * feat: clean up code * feat: clean up code * feat: update devices labels * feat: code cleanup * feat: combine filters * feat: add custom params check to enable filtering * feat: update docs to explain new filtering demo * feat: code cleanup * feat: use isTruthyCustomParamValue function * feat: update documentation * feat: use split * feat: code cleanup
* feat: add e2e tests for translations * feat: fix test * feat: clean up tests * feat: go back to the home page before opening a new movie page * feat: additional test for movie details page * feat: remove unnecessary code
* feat: fix filters not showing up for content lists * feat: fix content lists feedid in transform root func * feat: code cleanup * feat: add tests for content list * feat: code cleanup * feat: code cleanup, move reusable functions in util file * feat: remove filters from content list cases * feat: remove additional util file created, no longer needed * feat: clean up content lists tests * feat: remove failing tests, code cleanup * feat: code cleanup * feat: add more tests for video clicking * feat: use test-ids instead of div role attribute * feat: remove unnecessary test-id, use id instead * feat: fix snapshot * feat: fix favorites snalshot * feat: update screenshots * feat: code cleanup
* chore(deps): upgrade dependencies * chore: update snapshots * feat: update the footer url
|
Visit the preview URL for this PR (updated for commit 19efd5b): https://ottwebapp--pr693-feat-e2e-wcag-sib96ljs.web.app (expires Thu, 04 Sep 2025 09:07:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
AntonLantukh
force-pushed
the
develop
branch
from
63c5e93 to
f83ab7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will assess every page for WCAG 2.1 AA compliance using axe-playwright.
We have put a lot of effort into optimizing this project for accessibility over the last year. By reassessing WCAG compliance with every change, we aim to keep the bar high and ensure that no mistakes are accidentally introduced that degrade the accessibility state.
By automating this process, we make sure that tests are performed consistently and errors can be easily reproduced. Therefore, this has our preference instead of doing a manual test with the axe DevTools browser extension or Lighthouse.
We also added the possibility to disable rules or ignore certain elements for known issues. These should be documented in the test-script.
This change also contains a few minor accessibility optimizations.