enums and removing features n sharmk #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eating honey mustard with no burger
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alii
reviewed
Nov 25, 2025
| const schema = k.nativeEnum(Status); | ||
|
|
||
| it('should accept valid numeric enum values', () => { | ||
| assert.strictEqual(schema.parse(0), 0); |
Member
There was a problem hiding this comment.
Please also add enum tests for like
assert.strictEqual(schema.parse(Status.Pending), 0);
even though in theory it's still 0, it's nice to assure that contract
alii
reviewed
Nov 25, 2025
| }); | ||
| }); | ||
|
|
||
| describe('const enum compatibility', () => { |
Member
There was a problem hiding this comment.
this is not a const enum, this is an as const object. we should rename this test
a const enum is already a typescript thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.