Move most pub &mut self fns out of EventState; apply sel/key focus changes immediately #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This fixes the bug noted in #642: ime focus can now take effect when an editor without existing selection focus receives focus via touch input. |
dhardy
force-pushed
the
push-llnykpxvyvno
branch
from
741576b to
48c8ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a number of public
&mut selffns fromEventStateto eitherConfigCxorEventCx, as is most appropriate for usage.Also, this PR handles
request_sel_focusandrequest_key_focusimmediately instead of as a pending change. This improves compatibility withrequest_ime_focus, now renamed toreplace_ime_focusto emphasize that it shouldn't be called repeatedly except to change parameters.