resolve label jumps in text section #22
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type = node.type | ||
| center = case type | ||
| when :LIT, :INTEGER | ||
| output.puts " push 0x#{node.children.last.to_s(16)}" | ||
| output.puts " mov rax, 0x#{node.children.last.to_s(16)}" | ||
| return |
There was a problem hiding this comment.
The :LIT/:INTEGER branch now only emits mov rax, … and returns without pushing the value, but the rest of the generator still pops its operands from the stack (e.g., call_method and binary ops immediately pop arguments and conditions). Any expression or method call that uses a literal will now execute pop against an empty/uncorrelated stack, corrupting RSP and producing wrong results—1+2 or foo(1) will pop garbage instead of the literal.
Useful? React with 👍 / 👎.
| prologue_methods(output) | ||
| output.puts " .globl main" unless @shared | ||
| to_asm(@ast, output) |
There was a problem hiding this comment.
When any methods are defined, the compile branch now writes the prologue and calls to_asm but never emits the epilogue; unlike the no-methods branch, main is generated without stack restoration or an exit syscall. Programs that define methods now fall through after top-level code instead of returning/terminating cleanly, so execution continues into whatever bytes follow the generated main.
Useful? React with 👍 / 👎.
No description provided.