Support new instractions #24
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def parse_line(line) | ||
| line.split(/\s+/).reject { |o| o.empty? }.map { |op| op.gsub(/,/, "") } | ||
| return { label: line.delete_suffix(":"), size: 0 } if line.end_with?(":") | ||
| op, *operands = line.split(/\s+/).reject(&:empty?).map { it.gsub(/,/, "") } | ||
| size = instruction_size(op, *operands) |
There was a problem hiding this comment.
it in parse_line operand mapping
parse_line now maps operands with map { it.gsub(/,/, "") }, but Ruby does not provide an implicit it, so assembling any non-label line raises a NameError before opcode sizing occurs. This breaks all assembly paths (e.g., loading sample programs or running the new tests) because operand parsing fails. Use an explicit block argument or _1 instead.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
No. must use it for single-parameter blocks.
ruby 3.4 supports it for block single variable.
No description provided.