Fix TopocentricResidualPresenter #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the output methods `create_geojson_file` and `as_markdown` there is an implicit assumption about the order of coordinates in the structure `self._data["residuals"]`. Proj outputs coordinates in ENU order, hence, the assumption has been changed accordingly.
This effectively means that ENU-residuals are now computed as residual = target - model which is the usual way, and what is in fact done in the rest of the code base.
kbevers
force-pushed
the
fix_enupresenter
branch
from
5262413 to
e75e9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
residual = target-modelinstead of the other way round.