Skip to content

Fix Sherpa crash (again) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SanghyunKo wants to merge 234 commits into
base: GenWeightRefactor_master
Choose a base branch
from
Open

Fix Sherpa crash (again) #45

SanghyunKo wants to merge 234 commits into from
+2,896 −1,183

Conversation

@SanghyunKo
Copy link

@SanghyunKo SanghyunKo commented Nov 26, 2020

Sherpa sample crashes were originally fixed in #27, however, somehow overlooked in #41.

Adding weight -1 to group -1
----- Begin Fatal Exception 26-Nov-2020 07:49:03 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 33 event: 3206 stream: 0
   [1] Running path 'nanoAOD_step'
   [2] Calling method for module GenWeightProductProducer/'genWeights'
Exception Message:
A std::exception was thrown.
vector::_M_range_check: __n (which is 18446744073709551615) >= this->size() (which is 1)
----- End Fatal Exception -------------------------------------------------

cms::Exception has to be throw(n) explicitly to be caught. Also fixes the vector underflow (now findContainingWeightGroup returns -1, causing underflow).

kdlong and others added 30 commits May 27, 2019 20:33
@kdlong
Adding first outlines of weight products
208a4a3
@kdlong
Close to an outline, not working for LHESource
0a8810e
@kdlong
Working skeleton of LHEWeightInfoProduct
7cfc2fe
@kdlong
About a working outline with weights in the event
444dbc3
@kdlong
Working rough implementation of Weight/WeightInfo prods
49c25ba
@kdlong
Fix bug in insert to containedIds for WeightGroup
bb431b7
@kdlong
Add test scripts
df84164
@kdlong
Store pointers to WeightGroupInfo
23bee66 
First step to moving towards edm::OwnVector and polymorphic storage
@kdlong
Compiles with OwnVector, but need a proper copy constructor
0ba28e0
@kdlong
Working with edm::OwnVector
9ba9510
@kdlong
Separate WeightGroupInfo into .h and .cc files
338a979
@kdlong
Separate out PDF weights
8397fca
@kdlong
Add scale-specific weightgroupinfo class
9e06271
@dteague
First tests with parsing of lhe file. Need to incorp EDM lhe reader
071c069
@kdlong
Merge pull request #2 from dteague/Gen_parsing
f44363c 
First tests with parsing of lhe file. Need to incorp EDM lhe reader
@dteague
fixing readerhelper problems
6bfea57
@kdlong
Merge pull request #3 from dteague/Gen_parsing
9696885 
fixing readerhelper problems
@kdlong
Working on parsing integration with scale/pdf weights
f62468c
@dteague
Fixing little bit of readerhelper to change things to non-ptrs
28f0ba2
@dteague
Random commit before merge: only spacing diffs -_-
db06b18
@kdlong
Read header info from headers in externalLHEProducer
71629cd
@dteague
Merge branch 'GenWeightRefactor' of https://github.com/kdlong/cmssw i…
cf10a6b 
…nto Gen_parsing
@dteague
Merge branch 'GenWeightRefactor' of https://github.com/kdlong/cmssw i…
fbf495c 
…nto Gen_parsing
@dteague
added Regex helper class and put under (kinda silly) namespace
c98a078
@kdlong
Fix problem with instantiating Scale/PdfWeightInfo to file
de0ad7a
@kdlong
Add an alternative sample for testing
59691bc
@kdlong
Slight cleanup to naming and weightgroup type
1c1da76
@kdlong
Merge remote-tracking branch 'dylan/Gen_parsing' into dteague-Gen_par…
057cb83 
…sing
@dteague
Fixed small error in names of RegexCreater, should run on new gridp
80cde77 
Need to look into more flexible implimentation/more error detection
@kdlong
Merge remote-tracking branch 'dylan/Gen_parsing' into dteague-Gen_par…
41f2e17 
…sing
kdlong and others added 18 commits November 17, 2020 22:50
@kdlong
Merged GenWeightRefactor_master from repository kdlong with cms-merge…
20ef60f 
…-topic
@kdlong
code format
70855a9
@kdlong
Code format
30ae52f
@kdlong
Fix merge mistakes
45323bb
@sroychow
Merged refs/pull/32167/head from repository cms-sw with cms-merge-topic
b009ea6
@sroychow
fixing issues in build
7553ecb
@sroychow
moving throw to exception
f672f46
@kdlong
Merge pull request cms-sw#41 from sroychow/genrefactor_clonekdlong
752f300 
fixing build errors
@SanghyunKo
Merged GenWeightRefactor_master from repository kdlong with cms-merge…
999faba 
…-topic
@SanghyunKo
attempt to delete extra kets after the last </weightgroup>
7fd9c2c
@SanghyunKo
fix runtime error
0ef65ec
@SanghyunKo
failIfInvalidXML_ cleanup
3db8cfc
@SanghyunKo
failIfInvalidXML_ cleanup (2)
5db30d3
@SanghyunKo
scram b code-format
26e4edd
@kdlong
Merge pull request cms-sw#43 from SanghyunKo/GenWeightRefactor_master
d09e64d 
Fix runtime error
@SanghyunKo
fix Sherpa crashes
239fa5d
@SanghyunKo
code-formats
6036cab
@SanghyunKo
prevent underflow
a28751a
@SanghyunKo
Copy link
Author

SanghyunKo commented Nov 26, 2020

Tested with /GGJets_Pt-15_13TeV-sherpa/RunIISummer19UL17MiniAOD-106X_mc2017_realistic_v6-v2/MINIAODSIM and /DiPhotonJetsBox1BJet_MGG-80toInf_13TeV-sherpa/RunIISummer19UL18MiniAOD-106X_upgrade2018_realistic_v11_L1v1-v2/MINIAODSIM

@SanghyunKo SanghyunKo marked this pull request as draft November 26, 2020 08:18
@SanghyunKo SanghyunKo marked this pull request as ready for review November 26, 2020 08:18
@SanghyunKo
Copy link
Author

SanghyunKo commented Nov 26, 2020

Potential conflict/overlap with #42 (commit b38337e seems to handle the same issue)

@kdlong kdlong force-pushed the GenWeightRefactor_master branch 2 times, most recently from ffceb52 to caf24ab Compare January 16, 2022 22:44
@kdlong kdlong force-pushed the GenWeightRefactor_master branch 2 times, most recently from 036a6b4 to 0d3717a Compare April 19, 2022 14:00
@kdlong kdlong force-pushed the GenWeightRefactor_master branch 2 times, most recently from fe25f03 to f7a3156 Compare June 21, 2022 16:30
@kdlong kdlong force-pushed the GenWeightRefactor_master branch from f7a3156 to 393f1fc Compare July 11, 2022 08:19
@kdlong kdlong force-pushed the GenWeightRefactor_master branch from 258f6b0 to 5dee41c Compare December 14, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SanghyunKo @kdlong @dteague @guitargeek @sroychow