Skip to content

Conversation

@bpinto
Copy link
Contributor

@bpinto bpinto commented Aug 14, 2021

This is a controversial PR since it removes automated tests for no longer maintained nodes (6, 8, 10) as mocha no longer supports these node versions.

We may want to upgrade mocha to a not so recent version as for instance, mocha v7 only removed support for node 6.

@bpinto
Copy link
Contributor Author

bpinto commented Aug 15, 2021

I thought I was going to need a newer version of mocha for #309 but I don't think that's the case as I didn't end up using the Root Hook plugins approach - it didn't work as the plugin files are only loaded once and test-helper overrides Kefir on watch-mode.

In any case, I think dropping official support node 6 and 8 is probably something we want to do so that we can keep the dependencies up to date. While I think dropping support for node 10 might be needed to get the latest version of some libraries, we may want to hold it a little bit.

But, please let me know what you think and I'll do the changes (or close this PR).

bpinto added 2 commits August 20, 2021 14:24
- [x] mocha 7.0.0: dropped support for node v6.x
- [x] mocha 8.0.0: dropped support for node v8.x
- [x] mocha 8.0.0: deprecated mocha.opts
- [x] mocha 9.0.0: dropped support for node v10.x
@bpinto
Copy link
Contributor Author

bpinto commented Aug 20, 2021

Any opinions about this? I'd like to upgrade other dev dependencies though some of them no longer work on some node versions, so the decision we take here will have an impact on which other dev dependencies we could upgrade.

It's worth mentioning that the distributed code is not incompatible with those older node versions, it's just that we wouldn't be able to run the tests there.

@rpominov rpominov closed this in 6e4856e Jun 21, 2022
@rpominov
Copy link
Member

rpominov commented Jun 21, 2022

Thanks for the PR. Was easier for me to do it in master as I was fixing other things.

@bpinto bpinto deleted the mocha-upgrade branch June 21, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants