Skip to content

Fix async concurrency by replacing threading.RLock with asyncio.Lock #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pokliu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix async concurrency by replacing threading.RLock with asyncio.Lock #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py_eureka_client/eureka_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ def __init__(self,
assert ha_strategy in (HA_STRATEGY_RANDOM, HA_STRATEGY_STICK,
HA_STRATEGY_OTHER) if should_discover else True, f"do not support strategy {ha_strategy}"

self.__net_lock = RLock()
self.__net_lock = asyncio.Lock()
self.__eureka_server_conf = EurekaServerConf(
eureka_server=eureka_server,
eureka_domain=eureka_domain,
Expand Down Expand Up @@ -634,7 +634,7 @@ async def __try_all_eureka_servers(self, fun):
await self.__try_eureka_server_regardless_zones(fun)

async def __try_eureka_servers_in_list(self, fun, eureka_servers=[], zone=_DEFAUTL_ZONE):
with self.__net_lock:
async with self.__net_lock:
ok = False
_zone = zone if zone else _DEFAUTL_ZONE
for url in eureka_servers:
Expand Down