-
Notifications
You must be signed in to change notification settings - Fork 61
Test Vector Generation works again #35
Conversation
In addition to creating a bitcoin address, also generate a mnemonic key suitable for importing into common HD wallet software. This is an advanced function, and not suitable for most users, but may be useful to power users.
make build failed with: /bin/sh: 1: source: not found
bu renamed to ku (key utility) in pycoin version 0.40
bip39 mnemonic for HD wallets
based on http://github.com/trezor/python-mnemonic Sep 23, 2013 commit 8dae0cd4c01b219a83b310281febaffa0c13667e
files come from npm install bitcore-mnemonic
This reverts commit 9b7d422.
maxtaco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I'll try it out.
|
|
||
| ```sh | ||
| $ npm install -g iced-coffee-script | ||
| $ sudo ln -s /usr/bin/nodejs /usr/bin/node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these changes? I'm assuming you've installed node as your user and it's in your path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will remove this.
|
|
||
| ```sh | ||
| $ pip install virtualenv | ||
| $ sudo /usr/bin/easy_install virtualenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this line needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed only at the first run.
| @@ -1,8 +1,9 @@ | |||
|
|
|||
| SHELL := /bin/bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed? I use sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this the make build fails with this message:
/bin/sh: 1: source: not found
Makefile:15: recipe for target 'build-python' failed
make: *** [build-python] Error 127
I googled for "/bin/sh: 1: source: not found" and found this solution:
https://stackoverflow.com/questions/670191/getting-a-source-not-found-error-when-using-source-in-a-bash-script
I don'n know, I have a Ubuntu 16.04 LTS. What environment are you using for sh to find source?
Regeneration of Test Vectors now also add bip39 mnemonics belongs to the generated seeds
based on http://github.com/trezor/python-mnemonic Jul 22, 2018 commit 7d23efe34f3dd537996f31dae34f663207dac232
BIP39 Mnemonic addition
|
Sorry for these commits, I was not aware GitHub automatically adds new commits to my pull request. I will close this PR and make a new one, focusing only to make Test Vector Generation work. |
|
Let's try it again: #36 |
bu (bitcoin utils) has been renamed to ku (key utility) and its syntax changed
fixes #34