-
Notifications
You must be signed in to change notification settings - Fork 61
BIP39 Mnemonic addition #37
base: master
Are you sure you want to change the base?
Conversation
|
I personally would like to see this (or something similar) merged because
@maxtaco please let me know what you think about this! |
|
As I said in the other thread. 24 words gives no benefit over 12 words in this case. Read my messages in the other thread. |
|
also. don't commit node_modules folder. |
|
While I very much want to see either this or #22 in place, the commit graph for this pull request and therefore the changelist makes it difficult to follow the actual changeset. Can this be rebased or otherwise rebuilt into more coherent segments before being pulled? |
|
@dabura667 Ledger uses a 24 words recovery phrase. And all wallet who want to be compatible with Ledger has to accept 24 words. The node_modules is already included in the repo since 'release 1.0.9'. I thought it is a conscious design decision to include all vendor dependencies, and I just followed that. Although I am aware of issue #32 which asks for node_modules removal. |
|
@Shishire You are right, I will do a rebase to make this changeset more transparent. Thank you, stay tuned! |
In addition to creating a bitcoin address, also generate a mnemonic key suitable for importing into common HD wallet software. This is an advanced function, and not suitable for most users, but may be useful to power users.
based on http://github.com/trezor/python-mnemonic Jul 22, 2018 commit 7d23efe34f3dd537996f31dae34f663207dac232
Regeneration of Test Vectors now also add bip39 mnemonics belongs to the generated seeds
mention pbkdf2, bitcore-mnemonic and nodejs symlink
|
The node_modules related changes are removed. Commit graph and changeset is now tighter and cleaner. |
|
every one of those wallets is also good with 12 words. and most of them generate 12 words by default. "because Ledger does it" is a weak argument. Using 24 words has only demerits in the context of warp wallet when compared to 12 words. |
|
In this context it is irrelevant if these wallets generate 12-word passphrase by default. Because we would like to generate the passphrase with WarpWallet and the relevant point is: all of these wallets can accept 24 words. |
Generate BIP39 compatible word list suitable for import into HD wallets.