Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

Conversation

@gallizoltan
Copy link

Generate BIP39 compatible word list suitable for import into HD wallets.

@gallizoltan
Copy link
Author

I personally would like to see this (or something similar) merged because

  1. I think there would be a demand for it.
  2. Another brain wallet with BIP39 mnemonic is already available, but it uses only a single SHA-256 hash for seed generation, which can be dangerous. This could provide a safer alternative.

@maxtaco please let me know what you think about this!

@dabura667
Copy link

As I said in the other thread.

24 words gives no benefit over 12 words in this case.

Read my messages in the other thread.

@dabura667
Copy link

also. don't commit node_modules folder.

@TechyShishy
Copy link

While I very much want to see either this or #22 in place, the commit graph for this pull request and therefore the changelist makes it difficult to follow the actual changeset. Can this be rebased or otherwise rebuilt into more coherent segments before being pulled?

@gallizoltan
Copy link
Author

@dabura667 Ledger uses a 24 words recovery phrase. And all wallet who want to be compatible with Ledger has to accept 24 words.
Ledger, Trezor, Mycelium, Bither, Coinomi, MyEtherWallet, MyCrypto, Electrum: these are all good with 24 words.That is why I would like to use 24 words too.

The node_modules is already included in the repo since 'release 1.0.9'. I thought it is a conscious design decision to include all vendor dependencies, and I just followed that. Although I am aware of issue #32 which asks for node_modules removal.

@gallizoltan
Copy link
Author

gallizoltan commented Aug 8, 2018

@Shishire You are right, I will do a rebase to make this changeset more transparent. Thank you, stay tuned!

Gálli Zoltán and others added 7 commits August 8, 2018 22:07
In addition to creating a bitcoin address, also generate a mnemonic
key suitable for importing into common HD wallet software.  This
is an advanced function, and not suitable for most users, but may
be useful to power users.
based on http://github.com/trezor/python-mnemonic
Jul 22, 2018 commit 7d23efe34f3dd537996f31dae34f663207dac232
Regeneration of Test Vectors now also add bip39 mnemonics belongs to the
generated seeds
mention pbkdf2, bitcore-mnemonic and nodejs symlink
@gallizoltan
Copy link
Author

The node_modules related changes are removed. Commit graph and changeset is now tighter and cleaner.

@dabura667
Copy link

every one of those wallets is also good with 12 words. and most of them generate 12 words by default.

"because Ledger does it" is a weak argument.

Using 24 words has only demerits in the context of warp wallet when compared to 12 words.

@gallizoltan
Copy link
Author

In this context it is irrelevant if these wallets generate 12-word passphrase by default. Because we would like to generate the passphrase with WarpWallet and the relevant point is: all of these wallets can accept 24 words.
The only demerit with 24 words is you have to enter 24 words at wallet setup. Only once. But in this concept you don't have to memorize or write down these words, because these are deterministically generated by WarpWallet. So there is no other disadvantage of a longer word list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants