Skip to content

Fix compilation failure in CCL #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wnortje wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compilation failure in CCL #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/call-cc/handlers.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
(setf (symbol-value var) value)
(multiple-value-bind (dummies vals new setter getter)
(get-setf-expansion var)

(declare (ignorable getter))
(funcall
(compile nil
`(lambda ()
Expand Down
22 changes: 14 additions & 8 deletions src/walk.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
(cons walk-env lexical-env)))

(defun register-walk-env (env type name datum &rest other-datum)
(declare (ignorable other-datum))
(let ((walk-env (register (car env) type name datum))
(lexenv (case type
(:let (augment-with-variable (cdr env) name))
Expand Down Expand Up @@ -447,6 +448,7 @@
func))

(defun walk-lambda-list (lambda-list parent env &key allow-specializers macro-p)
(declare (ignorable macro-p))
(flet ((extend-env (argument)
(unless (typep argument 'allow-other-keys-function-argument-form)
(extend-walk-env env :let (name argument) argument))))
Expand Down Expand Up @@ -745,15 +747,19 @@

;;;; LOAD-TIME-VALUE

(defclass load-time-value-form (form)
((value :accessor value)
(read-only-p :accessor read-only-p)))
;;; Comment out these because it is redefined at the end of the file. SBCL does
;;; not complain. I assume it just overrides this definition with the new one.
;;; CCL gives a compilation failure.

(defwalker-handler load-time-value (form parent env)
(with-form-object (load-time-value load-time-value-form
:parent parent :source form)
(setf (value load-time-value) (walk-form (second form) load-time-value env)
(read-only-p load-time-value) (third form))))
;; (defclass load-time-value-form (form)
;; ((value :accessor value)
;; (read-only-p :accessor read-only-p)))

;; (defwalker-handler load-time-value (form parent env)
;; (with-form-object (load-time-value load-time-value-form
;; :parent parent :source form)
;; (setf (value load-time-value) (walk-form (second form) load-time-value env)
;; (read-only-p load-time-value) (third form))))

;;;; LOCALLY

Expand Down