Move the example config to example.config.json #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheToddLuci0
force-pushed
the
move_config_to_example
branch
from
aa1d4da to
3ae9248
Compare
Owner
|
Ehh, I think there's always going to be issues with people putting creds in files. Even with a name change, it's still just as easy for users to put their secrets in the |
Owner
|
Unless others have strong opinions on this, I plan on just keeping it the way it is. I usually just have a duplicate json file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid potential issues with people putting their actual secrets into a file tracked by git.
config.jsonis already in .gitignore, so should be good there.