Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 5, 2026 05:56
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.81%. Comparing base (6873250) to head (c6b9e00).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files          23       23           
  Lines        1707     1707           
  Branches      460      460           
=======================================
  Hits         1516     1516           
  Misses         54       54           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the behavior of materializeSlice to skip overlapping nested replacements instead of throwing an error. The implementation now silently ignores replacements that would overlap with previously applied ones, allowing the loader to continue processing template expressions that contain nested JSX transformations.

Key changes:

  • Modified error handling to skip overlapping replacements instead of throwing
  • Updated test expectations to reflect the new permissive behavior
  • Bumped package version from 1.7.0 to 1.7.1

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/loader/helpers/materialize-slice.ts Replaced error throwing with early return when overlapping replacements are detected
test/loader-internals.test.ts Updated test name and expectations to verify overlapping replacements are skipped
package.json Version bump to 1.7.1
package-lock.json Synchronized version with package.json

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 4506138 into main Jan 5, 2026
13 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 5, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants