Skip to content

Conversation

@knightedcodemonkey
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 11, 2026 18:46
@codecov
Copy link

codecov bot commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.81%. Comparing base (4506138) to head (fd27755).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   88.81%   88.81%           
=======================================
  Files          23       23           
  Lines        1707     1707           
  Branches      460      460           
=======================================
  Hits         1516     1516           
  Misses         54       54           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the reactJsx helper's TypeScript types with React's intrinsic element typings. It adds new type exports that re-use React's type definitions for intrinsic elements, refs, events, and DOM attributes, making the API more consistent with React's JSX types while maintaining backward compatibility.

Changes:

  • Adds comprehensive type-level test suite to ensure reactJsx types stay aligned with React intrinsics
  • Exports seven helper types from @knighted/jsx/react for users who need explicit type annotations
  • Updates documentation to clarify that reactJsx uses React's type definitions

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/react-jsx.types.test-d.ts New type-only test file that validates type alignment with React's JSX intrinsics using compile-time assertions
src/react/react-jsx.ts Adds new type imports from React and exports helper types that wrap React's intrinsic element types
src/react/index.ts Re-exports the new helper types to make them available from @knighted/jsx/react
package.json Version bump from 1.7.1 to 1.7.2
package-lock.json Corresponding lockfile update for version 1.7.2
docs/typescript.md Documents that reactJsx re-uses React's intrinsic element typings and mentions helper type exports
docs/runtime-helpers-overview.md Adds note about intrinsic props, events, and refs following React's typings
README.md Documents the new helper types and their availability
CHANGELOG.md Documents the typing improvements in the unreleased section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 11, 2026 19:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 37bc562 into main Jan 11, 2026
13 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch January 11, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants