-
Notifications
You must be signed in to change notification settings - Fork 3
Add body getter and support multipart/form-data enctype #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1 similar comment
d26cb35 to
e53b5b9
Compare
|
Is it better by an option? |
|
I think this is improved version for sure. Original one can only handle situations where |
|
I think we can use an option for enabling that. |
|
@fundon what's your plan for this PR? |
|
@clthck About an option? |
|
I don't think providing this as an option is not appropriate. It's not something user wants to opt in/out - it should be handled by default. There's no difference in overhead or whatever if we make this feature optable. |
This PR supports
req.bodygetter. E.g. I was using jquery-ujs for an anchor tag withdata-method="delete". Since jquery-ujs is originally designed for rails, it used form body to send hidden input field value with name of_method. And this obviously doesn't get passed query getter.