Савицких Антон #270
Open
Савицких Антон #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamnole
reviewed
Nov 17, 2025
Comment on lines
36
to
43
| if (Builder != null && Tokenizer != null) | ||
| { | ||
| var tokens = Tokenizer.Tokenize(text); | ||
| var ast = new SyntaxTree(tokens); | ||
| var convertedText = Builder.Build(ast); | ||
| return convertedText; | ||
| } | ||
| throw new NullReferenceException(); |
There was a problem hiding this comment.
Можно более явную ошибку об отсутствии билдера или токенайзера
Comment on lines
25
to
26
| public IBuilder Builder { get; } | ||
| public ITokenizer Tokenizer { get; } |
There was a problem hiding this comment.
Можно сделать приватными readonly полями, думаю конвертер не подразумевает отдельное их использование в обход своей логики
Comment on lines
+13
to
+17
| List<string> TextToLines(string text); | ||
|
|
||
| List<Token> TokenizeLines(IEnumerable<string> lines); | ||
|
|
||
| List<Token> TokenizeLine(string line); |
There was a problem hiding this comment.
Методы нигде не используются, думаю они не должны торчать наружу
Comment on lines
29
to
37
| _tagMapping = new Dictionary<NodeType, string> | ||
| { | ||
| { NodeType.Document, "" }, | ||
| { NodeType.Paragraph, "p" }, | ||
| { NodeType.Header, "h1" }, | ||
| { NodeType.Bold, "strong" }, | ||
| { NodeType.Italic, "em" }, | ||
| { NodeType.Text, "" } | ||
| }; |
There was a problem hiding this comment.
Может вынести куда-нибудь в отдельный файл или в поля класса, всё равно он не изменяется
| return; | ||
| } | ||
|
|
||
| if (currentChar == '_') |
There was a problem hiding this comment.
Давай '_' в какие-нибудь константы markdown и в похожих местах
|
|
||
| if (IsValidClosingMarker(line, currentPosition, true)) | ||
| { | ||
| var isEmptyWord = IsEmptyMarkedWord(currentPosition, startPosition, true); |
Comment on lines
208
to
218
| if (innerTokens.Count > 0) | ||
| { | ||
| FlushTextBufferIfNotEmpty(originalTextBuffer, tokens); | ||
| AddNestedItalicsTokens(textBuffer, tokens, innerTokens); | ||
| SkipBoldMarker(ref currentPosition); | ||
| return; | ||
| } | ||
|
|
||
| FlushTextBufferIfNotEmpty(originalTextBuffer, tokens); | ||
| AddTokensFromBufferWithSpecifiedTags(textBuffer, tokens, TokenType.BoldStart, TokenType.BoldEnd); | ||
| SkipBoldMarker(ref currentPosition); |
Comment on lines
284
to
306
| private void PrependMarkerToBuffer(StringBuilder textBuffer, bool isBold) | ||
| { | ||
| if (isBold) | ||
| { | ||
| textBuffer.Insert(0, "__"); | ||
| } | ||
| else | ||
| { | ||
| textBuffer.Insert(0, '_'); | ||
| } | ||
| } | ||
|
|
||
| private void AppendMarkerToBuffer(StringBuilder textBuffer, bool isBold) | ||
| { | ||
| if (isBold) | ||
| { | ||
| textBuffer.Append("__"); | ||
| } | ||
| else | ||
| { | ||
| textBuffer.Append('_'); | ||
| } | ||
| } |
Comment on lines
186
to
219
| private bool CanContinueParsingHeaderContent() | ||
| { | ||
| return currentIndex < tokens.Count && tokens[currentIndex].Type != TokenType.Newline; | ||
| } | ||
|
|
||
| private bool HasNewlineTokenAtCurrentPosition() | ||
| { | ||
| return currentIndex < tokens.Count && tokens[currentIndex].Type == TokenType.Newline; | ||
| } | ||
|
|
||
| private bool CanContinueParsingParagraphContent() | ||
| { | ||
| return currentIndex < tokens.Count && tokens[currentIndex].Type != TokenType.Newline; | ||
| } | ||
|
|
||
| private bool CanContinueParsingBoldContent() | ||
| { | ||
| return currentIndex < tokens.Count && tokens[currentIndex].Type != TokenType.BoldEnd; | ||
| } | ||
|
|
||
| private bool HasBoldEndTokenAtCurrentPosition() | ||
| { | ||
| return currentIndex < tokens.Count && tokens[currentIndex].Type == TokenType.BoldEnd; | ||
| } | ||
|
|
||
| private bool CanContinueParsingItalicContent() | ||
| { | ||
| return currentIndex < tokens.Count && tokens[currentIndex].Type != TokenType.ItalicsEnd; | ||
| } | ||
|
|
||
| private bool HasItalicsEndTokenAtCurrentPosition() | ||
| { | ||
| return currentIndex < tokens.Count && tokens[currentIndex].Type == TokenType.ItalicsEnd; | ||
| } |
There was a problem hiding this comment.
Кажется можно один или два метода сделать и переиспользовать
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ksamnole