Skip to content

fix(tooltip, popover): shadow for dark theme (#DS-4541) #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lskramarov merged 4 commits into from
Jan 16, 2026
Merged

fix(tooltip, popover): shadow for dark theme (#DS-4541) #1286

lskramarov merged 4 commits into from
Jan 16, 2026

Conversation

@lskramarov
Copy link
Contributor

@lskramarov lskramarov commented Jan 15, 2026

No description provided.

@lskramarov lskramarov requested a review from rmnturov January 15, 2026 17:06
@lskramarov lskramarov self-assigned this Jan 15, 2026
@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

Visit the preview URL for this PR (updated for commit 7767596):

https://koobiq-next--prs-1286-4qddj51g.web.app

(expires Wed, 21 Jan 2026 10:22:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@NikGurev
Copy link
Contributor

NikGurev commented Jan 16, 2026

Правил баг с "залезанием" бордера треугольника на кнопку, снова воспроизводится

image

@lskramarov
Copy link
Contributor Author

lskramarov commented Jan 16, 2026

Правил баг с "залезанием" бордера треугольника на кнопку, снова воспроизводится

image

сам тултип не "залазиет" это тень...

NikGurev
NikGurev approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@NikGurev NikGurev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поведение из DS-4125 не воспроизводится

@artembelik
Copy link
Contributor

artembelik commented Jan 16, 2026

нужно разобраться почему не упал скриншот тест, в этой или в отдельно задаче

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@lskramarov
Copy link
Contributor Author

lskramarov commented Jan 16, 2026

/approve-snapshots

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🔄 Updating snapshots.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

✅ Snapshots updated!

@lskramarov lskramarov merged commit d150109 into main Jan 16, 2026
8 checks passed
@lskramarov lskramarov deleted the fix/DS-4541 branch January 16, 2026 10:39
lskramarov added a commit that referenced this pull request Jan 16, 2026
@lskramarov
fix(tooltip, popover): shadow for dark theme (#DS-4541) (#1286)
70576dc
lskramarov added a commit that referenced this pull request Jan 16, 2026
@lskramarov
fix(tooltip, popover): shadow for dark theme (#DS-4541) (#1286) (#1289)
454f8e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artembelik artembelik artembelik approved these changes

@rmnturov rmnturov rmnturov approved these changes

@NikGurev NikGurev NikGurev approved these changes

Assignees

@lskramarov lskramarov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lskramarov @NikGurev @artembelik @rmnturov