Skip to content

fix(checkbox): unnecessary padding (#DS-4564) #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artembelik merged 1 commit into from
Jan 16, 2026
Merged

fix(checkbox): unnecessary padding (#DS-4564) #1291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 5 additions & 21 deletions packages/components/checkbox/checkbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@use '../core/styles/common/tokens' as *;
@use './checkbox-theme' as *;

.kbq-checkbox-checkmark,
Expand Down Expand Up @@ -27,10 +26,7 @@
}

.kbq-checkbox__layout {
$padding-left: kbq-sum-series-css-variables(
[checkbox-size-normal-width,
checkbox-size-normal-horizontal-content-padding]
);
--padding: calc(var(--kbq-checkbox-size-normal-width) + var(--kbq-checkbox-size-normal-horizontal-content-padding));

box-sizing: initial;

Expand All @@ -39,7 +35,7 @@

display: inline-flex;

max-width: calc(100% - $padding-left);
max-width: calc(100% - var(--padding));

// `cursor: inherit` ensures that the wrapper element gets the same cursor as the kbq-checkbox
// (e.g. pointer by default, regular when disabled), instead of the browser default.
Expand All @@ -49,7 +45,7 @@

padding-bottom: var(--kbq-checkbox-size-normal-padding-bottom);

padding-left: $padding-left;
padding-left: var(--padding);

vertical-align: top;
}
Expand Down Expand Up @@ -104,16 +100,7 @@
}

.kbq-checkbox.kbq-checkbox_big {
& .kbq-checkbox__layout {
$padding-left: kbq-sum-series-css-variables(
[ checkbox-size-normal-width,
checkbox-size-normal-horizontal-content-padding]
);

max-width: calc(100% - $padding-left);

padding-left: $padding-left;
}
--padding: calc(var(--kbq-checkbox-size-big-width) + var(--kbq-checkbox-size-big-horizontal-content-padding));

& .kbq-checkbox__inner-container {
top: var(--kbq-checkbox-size-big-top);
Expand Down Expand Up @@ -152,10 +139,7 @@
.kbq-checkbox_label-before {
.kbq-checkbox__layout {
padding-left: 0;
padding-right: kbq-sum-series-css-variables(
[ checkbox-size-normal-width,
checkbox-size-normal-horizontal-content-padding]
);
padding-right: var(--padding);
}

.kbq-checkbox__inner-container {
Expand Down