-
Notifications
You must be signed in to change notification settings - Fork 0
Update dependency highlight.js to v11 [SECURITY] #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/npm-highlight.js-vulnerability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44894b2 to
5848ab9
Compare
5848ab9 to
814095f
Compare
814095f to
b8ec5c0
Compare
b8ec5c0 to
44b5254
Compare
44b5254 to
0e59c7a
Compare
0e59c7a to
7c49080
Compare
7c49080 to
edbb22d
Compare
edbb22d to
c45ae59
Compare
c45ae59 to
7757490
Compare
7757490 to
079c54d
Compare
079c54d to
4e51773
Compare
4e51773 to
b988bf0
Compare
b988bf0 to
a0ddbc8
Compare
a0ddbc8 to
dabad97
Compare
6da1b95 to
03190b6
Compare
03190b6 to
67b9c64
Compare
67b9c64 to
2a4cdb3
Compare
2a4cdb3 to
6a6dd9e
Compare
6a6dd9e to
46c6b85
Compare
46c6b85 to
528559b
Compare
528559b to
a8581b8
Compare
a8581b8 to
d85f792
Compare
d85f792 to
d7c7a64
Compare
d7c7a64 to
ba4387c
Compare
ba4387c to
1da1ed2
Compare
1da1ed2 to
082c70b
Compare
082c70b to
93289f9
Compare
93289f9 to
8618568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^9.12.0→^11.0.0GitHub Vulnerability Alerts
GHSA-7wwv-vh3v-89cq
Impact: Potential ReDOS vulnerabilities (exponential and polynomial RegEx backtracking)
oswasp:
If are you are using Highlight.js to highlight user-provided data you are possibly vulnerable. On the client-side (in a browser or Electron environment) risks could include lengthy freezes or crashes... On the server-side infinite freezes could occur... effectively preventing users from accessing your app or service (ie, Denial of Service).
This is an issue with grammars shipped with the parser (and potentially 3rd party grammars also), not the parser itself. If you are using Highlight.js with any of the following grammars you are vulnerable. If you are using
highlightAutoto detect the language (and have any of these grammars registered) you are vulnerable. Exponential grammars (C, Perl, JavaScript) are auto-registered when using the common grammar subset/libraryrequire('highlight.js/lib/common')as of 10.4.0 - see https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@10.4.0/build/highlight.jsAll versions prior to 10.4.1 are vulnerable, including version 9.18.5.
Grammars with exponential backtracking issues:
And of course any aliases of those languages have the same issue. ie:
hppis no safer thancpp.Grammars with polynomial backtracking issues:
And again: any aliases of those languages have the same issue. ie:
rubyandrbshare the same ruby issues.Patches
Workarounds / Mitigations
References
For more information
If you have any questions or comments about this advisory:
Release Notes
highlightjs/highlight.js (highlight.js)
v11.11.1Compare Source
v11.11.0Compare Source
CAVEATS / POTENTIALLY BREAKING CHANGES
Core Grammars:
\Josh Goebel$()expressions aneesh98anchor-name,aspect-ratio,backdrop-filter,container,margin-trim,place-content,scroll-timeline, ...) BaliBalofile,args,dynamic,record,requiredandscopedAlvin JoytimeandcoprocÁlvaro Mondéjar|=operator false positives (as block arguments) Aboobacker MKaddbuiltin [h7x4][]oras builtin instead of literal [h7x4][]'''string escapes [h7x4][]"and''strings [h7x4][]conceptanddeferto list of Nim keywords Jake LeahyNew Grammars:
Developer Tools:
Themes:
Rosé Pinetheme William WilkinsonCybertopia Cherrytheme Alexandre ZANNICybertopia Dimmertheme Alexandre ZANNICybertopia Icecaptheme Alexandre ZANNICybertopia Saturatedtheme Alexandre ZANNIImprovements:
CONTRIBUTORS
v11.10.0Compare Source
CAVEATS / POTENTIALLY BREAKING CHANGES
Core Grammars:
satisfiesoperator Kisaragi Hiuorconflicts with string highlighting Mohamed Aliselfvariable [Lee Falin][]gototo be recognized as a keyword in Java Alvin JoysudoAlvin Joynewkeyword without capturing it within variables/class names Cameron Taylor_separators, add hex p exponents Lisa Ugrayjustify-itemsandjustify-selfattributes Vasily Polovnyovaccent-color,appearance,color-scheme,rotate,scaleandtranslateattributes Carl Räftingselect,option,optgroup,pictureandsourceto list of known tags Vasily Polovnyovinset,inset-*,border-start-*-radiusandborder-end-*-radiusattributes Vasily Polovnyovtext-decoration-skip-ink,text-decoration-thicknessandtext-underline-offsetattributes Vasily Polovnyovwhento be recognized as a keyword in Java Chiel van de SteegNew Grammars:
Developer Tool:
highlightAPI [Misha Kaletsky][]Themes:
1c-lighttheme a like in the IDE 1C:Enterprise 8 (for 1c) Vitaly Barilkov11.9.0Compare Source
CAVEATS / POTENTIALLY BREAKING CHANGES
nodebuildstyles/*.cssfiles now ship un-minifiedwith minified counterparts as:
styles/*.min.cssmvorisek(this makes things consistent with our
cdnbuilds)Parser:
New Grammars:
Core Grammars:
ifwhilefor[Omar Hussein][]x0-x30andw0-w30ARMv8 registers Nicholas Thompsonfinal,is,macrokeywords and$identifiers Robert Borgheseabstractdeclaration from keyword Robert Borghesemacrokeyword Bradley Mackey@uncheckedand@Sendablesupport Bradley Mackey//> using foo bar[Jamie Thompson][]!assertcompiler flag [idleberg][]eprintln!macro qoheniacwarn_unqualified_accessis an attribute Bradley Mackeyrecordandvaras keywords Guillaume LaforgeDeveloper Tool:
highlightAPI. Shah Shabbir Ahmmedv11.8.0Compare Source
Parser engine:
__emitTokenskey to grammars to allow then to direct their own parsing, only using Highlight.js for the HTML rendering Josh GoebelremovePluginapi faga295JavaScriptCyrus KaoNew Grammars:
Core Grammars:
_in variable names [joshgoebel][]protoalias for Protobuf [dimitropoulos][]base,interface,sealed, andwhenkeywords Sam Rawlins->operator legal) Keyacomselectanduntilas keywordsv11.7.0Compare Source
New Grammars:
Grammars:
scmalias for Scheme matyklug18<T =are not JSX Josh Goebel((keyword Nick Chambersimport()as a function, rather a keyword nathnolt((keyword Nick ChambersImprovements:
v11.6.0Compare Source
Supported Node.js versions:
Default build changes:
wasmto default:commonbuild (#3526) [Josh Goebel][]graphqlto default:commonbuild (#3526) [Josh Goebel][]Grammars:
keywordtoliteralshikhar13012001scopedkeyword in C# (#3571) [David Pine][]transparentkeyword Matt Bovel::(#3540) [Josh Goebel][]include_bytes!macro (#3541) Serial-ATA==as a variable declaration Mousetailanykeyword (#3515) Bradley Mackeydistributedkeyword Marcus Ortizmatchandcasekeywords Avrumy Lungerv11.5.1: Version 11.5.1Compare Source
Just a tiny release to hopefully fix the issues some are having with CSS not seen as having side effects with web pack, etc...
Packaging:
sideEffectfor css and scss files, fixes #3504v11.5.0Compare Source
Themes:
Tokyo-Night-darktheme Henri VandersleyenTokyo-Night-lighttheme Henri Vandersleyenpanda-syntax-darktheme Annmarie Switzerpanda-syntax-lighttheme Annmarie SwitzerNew Grammars:
Grammars:
typeandvariable.languagescopes Josh Goebel$pattern(numbers allowed in command names) Martin Mattelmeta.promptscope for REPL prompts, etc Josh Goebel***Hello world***without breaking Josh GoebelelseJosh Goebelv11.4.0Compare Source
New Language:
Themes:
Defaultis now much closer WCAG AA (contrast) (#3402) Josh GoebelDarknow meets WCAG AA (contrast) (#3402) Josh Goebelintellij-lighttheme Pegasisfelipectheme Felipe ContrerasThese changes should be for the better and should not be super noticeable but if you're super picky about your colors you may want to intervene here or copy over the older themes from 11.3 or prior.
Grammars:
vector<<template false positive (#3437) Josh Goebelnamespaceandusehighlighting (#3427) Josh Goebel$thisis avariable.languagenow (#3427) Josh Goebel__COMPILER_HALT_OFFSET__(#3427) Josh Goebelsealedandnon-sealedkeywords (#3386) Bradley MackeyCLASS_REFERENCE(#3411) Josh Goebel!(#3417) idleberg!(#3420) idlebergcommentmacro catches more than it should (#3395)$in symbol breaks highlightingregexmode to regex literalpunctuationmode for commas.jldoctestalias (#3432) Fons van der PlasDeveloper Tools:
Themes:
v11.3.1Compare Source
Build:
v11.3.0Compare Source
Build:
HighlightJSnamed export (#3295) Josh Goebel.defaultnamed export to CJS builds (#3333) Josh GoebelParser:
throwUnescapedHTMLto warn against potential HTML injection Josh Goebelregexhelper functions viahljsinjection Josh GoebelGrammars:
class X extends Y(#3278) Josh GoebelFloat32Arrayhighlighted incorrectly (#3353) Josh Goebelerrortype Josh GoebelSUBSTis no longer highlighted Josh Goebelxor_eqkeyword highlighting. Denis Kovalchukdoandthenkeyword (#3323) Nicolas Stuckienum,exportandgivenkeywords (#3328) Nicolas Stuckiextensionsoft keyword (#3326) Nicolas Stuckiendsoft keyword (#3327) Nicolas Stuckiinlinesoft keyword (#3329) Nicolas Stuckiusingsoft keyword (#3330) Nicolas Stuckif#alias (#3337) Bahnschriftcase_insensitivetotrue(#3351) idlebergv11.2.0Compare Source
Build:
Parser:
_(#3283) Josh Goebel__FILE__and__LINE__constants (#3283) Josh GoebelGrammars:
isolated/nonisolatedkeywords (#3296) Bradley MackeyNew Languages:
v11.1.0Compare Source
Grammars:
catchkeyword (#3251) Konrad Rudolphpwshalias (#3236) tebecoednalias (#3213) Stel Abregov11.0.1Compare Source
v11.0.0Compare Source
This is a major release. As such it contains breaking changes which may require action from users. Please read VERSION_11_UPGRADE.md for a detailed summary of all breaking changes.
Potentially breaking changes
Unless otherwise attributed items below are thanks to Josh Goebel (ref: #2558).
The below list should only be considered to be a high-level summary.
Deprecations / Removals / API Changes:
initHighlighting()andinitHighlightingOnLoad()deprecated. UsehighlightAll().highlightBlock(el)deprecated. UsehighlightElement(el)before:highlightBlock&after:highlightBlockcallbacks deprecated. Use equivalenthighlightElementcallbacks.highlight(languageName, code, ignoreIllegals, continuation)signature deprecated. Usehighlight(code, {language, ignoreIllegals}).highlight()signature no longer supportscontinuationargument.tabReplaceoption removed. Consider a plugin.useBRoption removed. Consider a plugin or CSS.requireLanguage()removed. UsegetLanguage().endSameAsBeginmode key removed. Usehljs.END_SAME_AS_BEGIN.lexemesmode key removed. Usekeywords.$pattern.Security:
Themes:
schoolbookhas been updated to remove the lined background.githubupdated to better match modern GitHub (#1616) [Jan Pilzer][]github-gisthas been removed in favor ofgithub[Jan Pilzer][]nnfxupdated for v11 xml styles and improved css supportLanguage Grammars:
Other changes
Parser:
beginScopeandendScopeto allow separate scoping begin and end (#3159) Josh GoebelendScopenow supports multi-class matchers as well (#3159) Josh GoebelhighlightElementnow always tags blocks with a consistentlanguage-[name]class Josh Goebelspantags now also always have thelanguage-prefix addedtitle.class.inheritedsub-scope support Josh Goebeltitle.classsub-scope support (#3078) Josh Goebeltitle.functionsub-scope support (#3078) Josh GoebelbeforeMatchcompiler extension (#3078) Josh GoebelcssSelectorconfiguration option (#3180) [James Edington][]Grammars:
.meta-keyword=>.meta .keyword(nested scopes) (#3167) Josh Goebel.meta-string=>.meta .string(nested scopes) (#3167) Josh Goebelactorkeyword (#3171) Bradley Mackey@resultBuilderattribute (#3151) Bradley Mackeypdealias (#3142) [Dylan McBean][]function.title=>title.function(#3078) Josh Goebelfunction.title=>title.function(#3078) Josh Goebelfunction.title=>title.function(#3078) Josh Goebelimpl(#3078) Josh GoebelConfiguration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.