Skip to content

Conversation

@Henry-YiW
Copy link
Collaborator

This is for the 3d reconstruction codes using MASt3r with the scaling codes that utilize the GNSS information tagged to the images to correctly scale the reconstructed pointcloud to make the pointcloud reflect the true distance between different points.

Also, this pull request is for lidar pointcloud colorization using the images captured from four cameras on the car. It utilizes the intrinsic and extrinsic matrices of the four cameras and the lidar extrinsic matrix.

@Henry-YiW Henry-YiW requested a review from krishauser as a code owner May 15, 2025 14:34
Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no readme for how this functionality is supposed to work. Also, the calibration is hard-coded rather than being read from settings.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be using the calibration given by the calibration team.

Copy link
Collaborator Author

@Henry-YiW Henry-YiW May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, professor. The numbers were from the calibration team. You mentioned I should read from settings. Is that I could just add an argument asking fro the intrinsic and extrinsic matrices' pathes, and load from the files at those pathes? @krishauser

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishauser Professor, I have fixed the issues. Please check and merge the PR.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Henry-YiW Henry-YiW requested a review from krishauser May 16, 2025 09:32
Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishauser krishauser merged commit 986a3fc into s2025 May 16, 2025
2 of 4 checks passed
@krishauser krishauser deleted the s2025_auto_inspection_henry branch May 16, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants