-
Notifications
You must be signed in to change notification settings - Fork 10
lidar_colorization and mast3r reconstruction codes added #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
krishauser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no readme for how this functionality is supposed to work. Also, the calibration is hard-coded rather than being read from settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be using the calibration given by the calibration team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, professor. The numbers were from the calibration team. You mentioned I should read from settings. Is that I could just add an argument asking fro the intrinsic and extrinsic matrices' pathes, and load from the files at those pathes? @krishauser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krishauser Professor, I have fixed the issues. Please check and merge the PR.
…nd clean those hard-coded data in codes
|
krishauser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM




This is for the 3d reconstruction codes using MASt3r with the scaling codes that utilize the GNSS information tagged to the images to correctly scale the reconstructed pointcloud to make the pointcloud reflect the true distance between different points.
Also, this pull request is for lidar pointcloud colorization using the images captured from four cameras on the car. It utilizes the intrinsic and extrinsic matrices of the four cameras and the lidar extrinsic matrix.