Skip to content

Conversation

@astefanutti
Copy link
Contributor

What this PR does / why we need it:

Prevent the recreation of the JobSet when its TTL duration has expired.

Fixes #2981

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from astefanutti. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19742327386

Details

  • 0 of 10 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 51.264%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/trainjob_controller.go 0 1 0.0%
pkg/util/trainjob/trainjob.go 0 4 0.0%
pkg/runtime/framework/plugins/jobset/jobset.go 0 5 0.0%
Totals Coverage Status
Change from base Build 19741789363: -0.2%
Covered Lines: 1237
Relevant Lines: 2413

💛 - Coveralls

@astefanutti
Copy link
Contributor Author

/assign @kubeflow/kubeflow-trainer-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JobSet completed but Trainer Controller keeps recreating Pods (V2.1.0)

2 participants