-
Notifications
You must be signed in to change notification settings - Fork 864
fix: pss-restricted-with-istio #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
Add security context and annotations for Istio traffic management. Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Pull Request Test Coverage Report for Build 20599754766Details
💛 - Coveralls |
Added a patch to modify the jobset-controller-manager deployment annotations and security context. Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
|
/retest |
Removed security context seccomp profile from deployment. Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Istio sidecar exclusion configuration and seccomp security profiles to improve compatibility with Pod Security Standards (PSS) restricted policies when using Istio service mesh. The changes ensure that webhook traffic on port 9443 bypasses the Istio sidecar and adds RuntimeDefault seccomp profiles for enhanced security.
Key Changes:
- Added Istio traffic exclusion annotation for inbound port 9443 to prevent sidecar interference with webhook communication
- Configured RuntimeDefault seccomp profiles at the pod security context level for compliance with restricted PSS
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| manifests/third-party/jobset/kustomization.yaml | Adds kustomize patch for jobset-controller-manager deployment with Istio annotation and seccomp profile |
| manifests/base/manager/manager.yaml | Updates trainer manager deployment with Istio exclusion annotation and seccomp security context |
| charts/kubeflow-trainer/templates/manager/deployment.yaml | Adds Istio traffic exclusion annotation to Helm chart template for trainer manager |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed security context seccompProfile configuration. Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Removed security context seccompProfile from spec. Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@andreyvelich i am waiting for this to merge kubeflow/manifests#3314 |
andreyvelich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@juliusvonkohout Can you rebase this PR to fix CI please ?
/cc @tenzen-y @astefanutti
@andreyvelich may you also patch it in helm for the jobset ?