Skip to content

Conversation

@juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Dec 5, 2025

@andreyvelich may you also patch it in helm for the jobset ?

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Add security context and annotations for Istio traffic management.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Dec 5, 2025
@coveralls
Copy link

coveralls commented Dec 5, 2025

Pull Request Test Coverage Report for Build 20599754766

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.435%

Totals Coverage Status
Change from base Build 19935327740: 0.0%
Covered Lines: 1237
Relevant Lines: 2405

💛 - Coveralls

Added a patch to modify the jobset-controller-manager deployment annotations and security context.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Dec 5, 2025
@juliusvonkohout juliusvonkohout changed the title pss-restricted-fixes fix: pss-restricted-with-istio Dec 5, 2025
@juliusvonkohout
Copy link
Member Author

/retest

Removed security context seccomp profile from deployment.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 30, 2025 15:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Istio sidecar exclusion configuration and seccomp security profiles to improve compatibility with Pod Security Standards (PSS) restricted policies when using Istio service mesh. The changes ensure that webhook traffic on port 9443 bypasses the Istio sidecar and adds RuntimeDefault seccomp profiles for enhanced security.

Key Changes:

  • Added Istio traffic exclusion annotation for inbound port 9443 to prevent sidecar interference with webhook communication
  • Configured RuntimeDefault seccomp profiles at the pod security context level for compliance with restricted PSS

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
manifests/third-party/jobset/kustomization.yaml Adds kustomize patch for jobset-controller-manager deployment with Istio annotation and seccomp profile
manifests/base/manager/manager.yaml Updates trainer manager deployment with Istio exclusion annotation and seccomp security context
charts/kubeflow-trainer/templates/manager/deployment.yaml Adds Istio traffic exclusion annotation to Helm chart template for trainer manager

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Removed security context seccompProfile configuration.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@kubeflow kubeflow deleted a comment from Copilot AI Dec 30, 2025
Removed security context seccompProfile from spec.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juliusvonkohout
Once this PR has been reviewed and has the lgtm label, please ask for approval from andreyvelich. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member Author

@andreyvelich i am waiting for this to merge kubeflow/manifests#3314
/lgtm from my side if the tests are green.
Maybe you have to rebase the branch.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@juliusvonkohout Can you rebase this PR to fix CI please ?
/cc @tenzen-y @astefanutti

@google-oss-prow google-oss-prow bot added the lgtm label Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants