Skip to content

Conversation

@containermom
Copy link

The custom gate job duplicated protections already provided by Prow and GitHub org-level rulesets in the kubernetes-sigs org. Fork PRs don't receive secrets by default, and Prow's ok-to-test mechanism handles external contributor approval.

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Helm chart change
  • Other (please describe)

Testing

  • Unit tests added/updated
  • Helm chart tests pass (helm lint and template validation)
  • Tested changes manually
  • Added examples for new features

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated the relevant CRDs if needed
  • I have updated the Helm chart version if needed
  • I have added tests that prove my fix is effective or that my feature works

Additional context

The custom gate job duplicated protections already provided by Prow
and GitHub org-level rulesets in the kubernetes-sigs org. Fork PRs
don't receive secrets by default, and Prow's ok-to-test mechanism
handles external contributor approval.

Signed-off-by: Josephine Pfeiffer <hi@josie.lol>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: containermom
Once this PR has been reviewed and has the lgtm label, please assign pfeifferj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.66%. Comparing base (0783b6d) to head (8dc1937).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   55.66%   55.66%           
=======================================
  Files          58       58           
  Lines        8705     8705           
=======================================
  Hits         4846     4846           
  Misses       3515     3515           
  Partials      344      344           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants