-
Notifications
You must be signed in to change notification settings - Fork 481
Add replica_role label to metrics for HA setups #8080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add replica_role label to metrics for HA setups #8080
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: IrvingMg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/hold Please start with logs only PR. It will be much easier to review. Once we have the mechanism the follow up for metrics should be easy to digest. |
I’ve created #8107 for logs only. Once that’s ready, I’ll update the current PR with the metrics. |
b13e54b to
a361a63
Compare
a361a63 to
5bd9f29
Compare
The current PR has been updated and is now ready for review. It includes only the metrics-related changes. |
5bd9f29 to
cbe1590
Compare
cbe1590 to
e9507de
Compare
|
/unhold /cc @mimowo |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds replica_role label to metrics to indicate whether they were emitted by the leader, a follower, or a standalone Kueue instance (default when leader election is disabled).
Which issue(s) this PR fixes:
Closes #6772
Special notes for your reviewer:
Does this PR introduce a user-facing change?