Skip to content

Conversation

@IrvingMg
Copy link
Contributor

@IrvingMg IrvingMg commented Dec 4, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds replica_role label to metrics to indicate whether they were emitted by the leader, a follower, or a standalone Kueue instance (default when leader election is disabled).

Which issue(s) this PR fixes:

Closes #6772

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Metrics now include `replica_role` label to identify Kueue instance roles (leader/follower/standalone).```

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IrvingMg
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit e9507de
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/693994b717ccf60008eb6190
😎 Deploy Preview https://deploy-preview-8080--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2025
@mimowo
Copy link
Contributor

mimowo commented Dec 5, 2025

/hold
Let's don't mix the two at the PR level.

Please start with logs only PR. It will be much easier to review.

Once we have the mechanism the follow up for metrics should be easy to digest.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@IrvingMg
Copy link
Contributor Author

IrvingMg commented Dec 5, 2025

Please start with logs only PR. It will be much easier to review.

I’ve created #8107 for logs only. Once that’s ready, I’ll update the current PR with the metrics.

@IrvingMg IrvingMg marked this pull request as draft December 5, 2025 21:37
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 5, 2025
@IrvingMg IrvingMg force-pushed the feature/improve-logs-metrics-ha branch from b13e54b to a361a63 Compare December 9, 2025 15:29
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 9, 2025
@IrvingMg IrvingMg changed the title Add replica_role label to metrics and replica-role field to logs Add replica_role label to metrics for HA setups Dec 9, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2025
@IrvingMg IrvingMg force-pushed the feature/improve-logs-metrics-ha branch from a361a63 to 5bd9f29 Compare December 10, 2025 15:16
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2025
@IrvingMg IrvingMg marked this pull request as ready for review December 10, 2025 15:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025
@k8s-ci-robot k8s-ci-robot requested a review from pajakd December 10, 2025 15:17
@IrvingMg
Copy link
Contributor Author

I’ve created #8107 for logs only. Once that’s ready, I’ll update the current PR with the metrics.

The current PR has been updated and is now ready for review. It includes only the metrics-related changes.

@IrvingMg IrvingMg force-pushed the feature/improve-logs-metrics-ha branch from 5bd9f29 to cbe1590 Compare December 10, 2025 15:36
@IrvingMg IrvingMg force-pushed the feature/improve-logs-metrics-ha branch from cbe1590 to e9507de Compare December 10, 2025 15:41
@IrvingMg
Copy link
Contributor Author

/unhold

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo December 11, 2025 07:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve emitting logs and metrics in the HA setup

3 participants