Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Run AI workloads on Macbook's GPU in Kubernetes using the new `krunkit driver`.
* Don't call startKicServiceTunnel for non-kic drivers (#20863)
* krunkit: Disable offloading for faster networking (#21341)

## Deprication
## Deprecation
* Deprecate HyperKit driver with warning (#21024)

## Bug fixes
Expand Down Expand Up @@ -365,7 +365,7 @@ Improvements:
* Improved error message when enabling KVM addons on non-KVM cluster [#19195](https://github.com/kubernetes/minikube/pull/19195)
* Added warning when loading image with wrong arch [#19229](https://github.com/kubernetes/minikube/pull/19229)
* `profile list --output json` handle empty config folder [#16900](https://github.com/kubernetes/minikube/pull/16900)
* Check connectivity outside minikube when connectivity issuse [#18859](https://github.com/kubernetes/minikube/pull/18859)
* Check connectivity outside minikube when connectivity issues [#18859](https://github.com/kubernetes/minikube/pull/18859)

Bugs:
* Fix not creating API server tunnel for QEMU w/ builtin network [#19191](https://github.com/kubernetes/minikube/pull/19191)
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ MARKDOWNLINT ?= markdownlint
MINIKUBE_MARKDOWN_FILES := README.md CONTRIBUTING.md CHANGELOG.md

# The `libvirt_dlopen` build tag is used only linux to avoid linking with
# libvirt shared library. This is not documnted but can be found in the source.
# libvirt shared library. This is not documented but can be found in the source.
# https://gitlab.com/libvirt/libvirt-go-module/-/blob/f7cdeba9979dd248582901d2aaf7ab1f2d27cbe0/domain.go#L30
MINIKUBE_BUILD_TAGS := libvirt_dlopen

Expand Down
2 changes: 1 addition & 1 deletion hack/benchmark/time-to-k8s/page.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func main() {
apps := make(map[string]runs)

if err := readInCSV(*csvPath, apps); err != nil {
log.Fatalf("fail to readin cvs file with err %s", err)
log.Fatalf("fail to read in cvs file with err %s", err)
}

runningTime, cpuMdPlot, cpuChartPlot, totals, names := values(apps)
Expand Down
4 changes: 2 additions & 2 deletions hack/prow/minitest/deployer/boskos_deployer.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ type MiniTestBosKosDeployer struct {
sshAddr string

boskosClient *client.Client
// this channel serves as a signal channel for the hearbeat goroutine
// this channel serves as a signal channel for the heartbeat goroutine
// so that it can be explicitly closed
boskosHeartbeatClose chan struct{}
}
Expand Down Expand Up @@ -104,7 +104,7 @@ func (m *MiniTestBosKosDeployer) Up() error {
return err
}
if err := sshConnectionCheck(m.ctx, m.remoteUserName, m.sshAddr, nil); err != nil {
klog.Errorf("Failed to conntect via ssh: %v", err)
klog.Errorf("Failed to connect via ssh: %v", err)
return err
}

Expand Down
4 changes: 2 additions & 2 deletions hack/prow/minitest/deployer/docker_deployer.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ func (m *MiniTestDockerDeployer) Up() error {

// check ssh connectivity
if err := sshConnectionCheck(m.ctx, m.remoteUserName, "localhost", m.sshAdditionalArgs()); err != nil {
klog.Errorf("Failed to conntect via ssh: %v", err)
return fmt.Errorf("Failed to conntect via ssh: %v", err)
klog.Errorf("Failed to connect via ssh: %v", err)
return fmt.Errorf("Failed to connect via ssh: %v", err)
}

m.isUp = true
Expand Down
4 changes: 2 additions & 2 deletions hack/prow/prow.mk
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ----------------------------------------------------------------
# Bellow Integration tests run in a prow container (no external cloud vm)
# Below Integration tests run in a prow container (no external cloud vm)
# ----------------------------------------------------------------
.PHONY: integration-prow-kvm-docker-linux-x86-64
integration-prow-docker-docker-linux-x86-64:
Expand All @@ -21,7 +21,7 @@ integration-prow-docker-crio-linux-x86-64:
./hack/prow/util/integration_prow_wrapper.sh ./hack/prow/integration_docker_crio_linux_x86-64.sh

# ----------------------------------------------------------------
# Bellow Integration tests run in cloud VM using boskos
# Below Integration tests run in cloud VM using boskos
# ----------------------------------------------------------------

.PHONY: integration-prow-none-docker-linux-x86-64
Expand Down
2 changes: 1 addition & 1 deletion pkg/drivers/common/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ func parseDHCPdLeasesFile(file io.Reader) ([]DHCPEntry, error) {
}

// parseMAC parse both standard fixed size MAC address "%02x:..." and the
// variable size MAC address on drawin "%x:...".
// variable size MAC address on Darwin "%x:...".
func parseMAC(mac string) (net.HardwareAddr, error) {
hw := make(net.HardwareAddr, 6)
n, err := fmt.Sscanf(mac, "%x:%x:%x:%x:%x:%x",
Expand Down
2 changes: 1 addition & 1 deletion pkg/drivers/kic/oci/oci.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func CreateContainerNode(p CreateParams) error { //nolint to suppress cyclomatic
"--security-opt", "seccomp=unconfined", // ignore seccomp
"--tmpfs", "/tmp", // various things depend on working /tmp
"--tmpfs", "/run", // systemd wants a writable /run
// logs,pods be stroed on filesystem vs inside container,
// logs,pods be stored on filesystem vs inside container,
// some k8s things want /lib/modules
"-v", fmt.Sprintf("%s:/lib/modules:ro", kernelModulesPath()),
"--hostname", p.Name, // make hostname match container name
Expand Down
2 changes: 1 addition & 1 deletion pkg/drivers/krunkit/krunkit.go
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ func (d *Driver) stopKrunkit() error {
// No pidfile.
return nil
}
log.Debugf("Terminte krunkit (pid=%d)", pid)
log.Debugf("Terminate krunkit (pid=%d)", pid)
if err := process.Terminate(pid, driverName); err != nil {
if err != os.ErrProcessDone {
return err
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/bootstrapper/kubeadm/kubeadm.go
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ func (k *Bootstrapper) restartPrimaryControlPlane(cfg config.ClusterConfig) erro
return err
}
if err = retry.Expo(addonPhase, 100*time.Microsecond, 30*time.Second); err != nil {
klog.Warningf("addon install failed, wil retry: %v", err)
klog.Warningf("addon install failed, will retry: %v", err)
return errors.Wrap(err, "addons")
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/download/gh/gh.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
)

// ReleaseAssets retrieves a GitHub release by tag from org/project.
// Try to not call this too often. preferably cache and re-use. to avoid rate limits.
// Try to not call this too often. preferably cache and reuse. to avoid rate limits.
func ReleaseAssets(org, project, tag string) ([]*github.ReleaseAsset, error) {
ctx := context.Background()
// Use an authenticated client when GITHUB_TOKEN is set to avoid low rate limits.
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/shell/shell_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,6 @@ func TestSetScript(t *testing.T) {
t.Fatalf("Unexpected error: '%v' during Setting script", err)
}
if w.String() != "foo" {
t.Fatalf("Expected foo writed by SetScript, but got '%v'", w.String())
t.Fatalf("Expected foo written by SetScript, but got '%v'", w.String())
}
}
2 changes: 1 addition & 1 deletion site/content/en/docs/contrib/tests.en.md
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ for the platforms that support it, we're testing:
#### validatePersistentVolumeClaim
makes sure PVCs work properly
verifies at least one StorageClass exists
Applies a PVC manifest (pvc.yaml) and verfies PVC named myclaim reaches phase Bound.
Applies a PVC manifest (pvc.yaml) and verifies PVC named myclaim reaches phase Bound.
Creates a test pod (sp-pod) that mounts the claim (via createPVTestPod).
Writes a file foo to the mounted volume at /tmp/mount/foo.
Deletes the pod, recreates it, and verifies the file foo still exists by listing /tmp/mount, proving data persists across pod restarts.
Expand Down
4 changes: 2 additions & 2 deletions site/content/en/docs/tutorials/ai-playground.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ brew install krunkit
krunkit --version
```

Instal latest vmnet-helper:
Install latest vmnet-helper:

```shell
curl -fsSL https://github.com/minikube-machine/vmnet-helper/releases/latest/download/install.sh | bash
Expand Down Expand Up @@ -406,7 +406,7 @@ EOF

We configured our llama-server OpenAI compatible API endpoints using the
`OPENAI_API_BASE_URLS` environment variable.
Check [Open WebUI documenation](https://docs.openwebui.com) to learn how to
Check [Open WebUI documentation](https://docs.openwebui.com) to learn how to
configure it using the Admin Panel.

Wait until the deployment is available:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ apiserver: Running
kubeconfig: Configured
```

- For a HA cluster, kubeconfig points to the Virual Kubernetes API Server IP
- For a HA cluster, kubeconfig points to the Virtual Kubernetes API Server IP

```shell
kubectl config view --context ha-demo
Expand Down
2 changes: 1 addition & 1 deletion test/integration/functional_test_pvc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import (

// validatePersistentVolumeClaim makes sure PVCs work properly
// verifies at least one StorageClass exists
// Applies a PVC manifest (pvc.yaml) and verfies PVC named myclaim reaches phase Bound.
// Applies a PVC manifest (pvc.yaml) and verifies PVC named myclaim reaches phase Bound.
// Creates a test pod (sp-pod) that mounts the claim (via createPVTestPod).
// Writes a file foo to the mounted volume at /tmp/mount/foo.
// Deletes the pod, recreates it, and verifies the file foo still exists by listing /tmp/mount, proving data persists across pod restarts.
Expand Down